You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* add skeleton for global_search plugin
* base implementation of the server-side service
* add utils tests
* add server-side mocks
* move take_in_array to common folder
* implements base of client-side plugin
* add tests for server-side service
* fix server plugin tests
* implement `navigateToUrl` core API
* extract processResults for the client-side
* fetch server results from the client side
* factorize process_results
* fix plugin start params
* move things around
* move all server types to single file
* fix types imports
* add basic FTR tests
* add client-side service tests
* add tests for addNavigate
* add getDefaultPreference & tests
* use optional for RequestHandlerContext
* add registerRoutes test
* add base test for context
* resolve TODO
* common nits/doc
* common nits/doc on public
* update CODEOWNERS
* add import for declare statement
* add license check on the server-side
* add license check on the client-side
* eslint
* address some review comments
* use properly typed errors for obs
* add integration tests for the find endpoint
* fix unit tests
* use licensing start contract
* translate the error message
* fix eslint rule for test_utils
* fix test_utils imports
* remove NavigableGlobalSearchResult, use `application.navigateToUrl` instead.
* use coreProvider plugin in FTR tests
* nits
* fix service start params
* fix service start params, bis
* I really need to fix this typecheck oom error
* add README, update missing jsdoc
* nits on doc
- The `registerResultProvider` setup APIs share the same signature, however the input `GlobalSearchResultProvider`
305
288
types are different on the client and server.
306
289
- The `find` start API signature got a `KibanaRequest` for `server`, when this parameter is not present for `public`.
307
-
- The `find` API returns a observable of `NavigableGlobalSearchResult` instead of plain `GlobalSearchResult`. This type
308
-
is here to enhance results with a `navigate` method to let the `GlobalSearch` plugin handle the navigation logic, which is
309
-
non-trivial. See the [Redirecting to a result](#redirecting-to-a-result) section for more info.
310
290
311
291
#### http API
312
292
@@ -395,14 +375,11 @@ In current specification, the only conversion step is to transform the `result.u
395
375
396
376
#### redirecting to a result
397
377
398
-
Parsing a relative or absolute result url to perform SPA navigation can be non trivial, and should remains the responsibility
399
-
of the GlobalSearch plugin API.
400
-
401
-
This is why `NavigableGlobalSearchResult.navigate` has been introduced on the client-side version of the `find` API
378
+
Parsing a relative or absolute result url to perform SPA navigation can be non trivial. This is why `ApplicationService.navigateToUrl` has been introduced on the client-side core API
402
379
403
-
When using `navigate` from a result instance, the following logic will be executed:
380
+
When using `navigateToUrl` with the url of a result instance, the following logic will be executed:
404
381
405
-
If all these criteria are true for `result.url`:
382
+
If all these criteria are true for `url`:
406
383
407
384
- (only for absolute URLs) The origin of the URL matches the origin of the browser's current location
408
385
- The pathname of the URL starts with the current basePath (eg. /mybasepath/s/my-space)
0 commit comments