From bc09b1e01fc733da90d29601c21101aa99c0914d Mon Sep 17 00:00:00 2001 From: Tim Sullivan Date: Thu, 6 Jul 2023 21:02:46 -0700 Subject: [PATCH] [Global Search Bar] Ensure the search controls are visible in low DPI screens (#161398) ## Summary Closes https://github.com/elastic/kibana/issues/154415 by applying the fix suggested by Cee Chen. image image ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --- .../global_search_bar/public/components/search_bar.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/x-pack/plugins/global_search_bar/public/components/search_bar.tsx b/x-pack/plugins/global_search_bar/public/components/search_bar.tsx index a1c854b393d63..7571a656e5f68 100644 --- a/x-pack/plugins/global_search_bar/public/components/search_bar.tsx +++ b/x-pack/plugins/global_search_bar/public/components/search_bar.tsx @@ -18,6 +18,7 @@ import { euiSelectableTemplateSitewideRenderOptions, useEuiTheme, } from '@elastic/eui'; +import { css } from '@emotion/react'; import type { GlobalSearchFindParams, GlobalSearchResult } from '@kbn/global-search-plugin/public'; import React, { FC, useCallback, useEffect, useRef, useState } from 'react'; import useDebounce from 'react-use/lib/useDebounce'; @@ -317,6 +318,12 @@ export const SearchBar: FC = (opts) => { popoverButtonBreakpoints={['xs', 's']} singleSelection={true} renderOption={(option) => euiSelectableTemplateSitewideRenderOptions(option, searchTerm)} + listProps={{ + className: 'eui-yScroll', + css: css` + max-block-size: 75vh; + `, + }} searchProps={{ autoFocus: chromeStyle === 'project', value: searchValue,