From 755b92b5efbd757e5cc326e3098829e134fbe28b Mon Sep 17 00:00:00 2001
From: Matt Apperson <me@mattapperson.com>
Date: Tue, 6 Nov 2018 18:49:39 -0500
Subject: [PATCH] dont allow tag creation if id is invalid (#25133)

---
 .../public/pages/main/create_tag_fragment.tsx                 | 4 +++-
 x-pack/plugins/beats_management/public/pages/tag/index.tsx    | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/x-pack/plugins/beats_management/public/pages/main/create_tag_fragment.tsx b/x-pack/plugins/beats_management/public/pages/main/create_tag_fragment.tsx
index e0f561d10e6f4..f827eb6c09b1b 100644
--- a/x-pack/plugins/beats_management/public/pages/main/create_tag_fragment.tsx
+++ b/x-pack/plugins/beats_management/public/pages/main/create_tag_fragment.tsx
@@ -73,7 +73,9 @@ export class CreateTagFragment extends React.PureComponent<TagPageProps, TagPage
             <EuiButton
               fill
               disabled={
-                this.state.tag.id === '' || this.state.tag.configuration_blocks.length === 0
+                this.state.tag.id.search(/^[a-zA-Z0-9-]+$/) === -1 ||
+                this.state.tag.id === '' ||
+                this.state.tag.configuration_blocks.length === 0
               }
               onClick={this.saveTag}
             >
diff --git a/x-pack/plugins/beats_management/public/pages/tag/index.tsx b/x-pack/plugins/beats_management/public/pages/tag/index.tsx
index 1d3bebf9f5859..9655efc64ddbf 100644
--- a/x-pack/plugins/beats_management/public/pages/tag/index.tsx
+++ b/x-pack/plugins/beats_management/public/pages/tag/index.tsx
@@ -85,7 +85,9 @@ export class TagPageComponent extends React.PureComponent<TagPageProps, TagPageS
               <EuiButton
                 fill
                 disabled={
-                  this.state.tag.id === '' || this.getNumExclusiveConfigurationBlocks() > 1 // || this.state.tag.configuration_blocks.length === 0
+                  this.state.tag.id.search(/^[a-zA-Z0-9-]+$/) === -1 ||
+                  this.state.tag.id === '' ||
+                  this.getNumExclusiveConfigurationBlocks() > 1 // || this.state.tag.configuration_blocks.length === 0
                 }
                 onClick={this.saveTag}
               >