From 716252882e3cd2ee44ea9d2231acaecec5021683 Mon Sep 17 00:00:00 2001
From: Ryland Herrick <ryalnd@gmail.com>
Date: Thu, 13 Feb 2020 17:38:02 -0600
Subject: [PATCH] style: Prefer null coalescing over ternary

---
 .../detection_engine/routes/rules/create_rules_bulk_route.ts   | 3 +--
 .../lib/detection_engine/routes/rules/create_rules_route.ts    | 3 +--
 .../detection_engine/routes/rules/update_rules_bulk_route.ts   | 3 +--
 .../lib/detection_engine/routes/rules/update_rules_route.ts    | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.ts
index 057c5fde5b599..51b7b132fc794 100644
--- a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.ts
+++ b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_bulk_route.ts
@@ -81,8 +81,7 @@ export const createCreateRulesBulkRoute = (
             } = payloadRule;
             const ruleIdOrUuid = ruleId ?? uuid.v4();
             try {
-              const finalIndex =
-                outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+              const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
               const indexExists = await getIndexExists(clusterClient.callAsCurrentUser, finalIndex);
               if (!indexExists) {
                 return createBulkErrorObject({
diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.ts
index 758f82bdbce80..19e772165628d 100644
--- a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.ts
+++ b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/create_rules_route.ts
@@ -75,8 +75,7 @@ export const createCreateRulesRoute = (
           return headers.response().code(404);
         }
 
-        const finalIndex =
-          outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+        const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
         const indexExists = await getIndexExists(clusterClient.callAsCurrentUser, finalIndex);
         if (!indexExists) {
           return headers
diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.ts
index 2f15454d96606..98ed01474c3dc 100644
--- a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.ts
+++ b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_bulk_route.ts
@@ -74,8 +74,7 @@ export const createUpdateRulesBulkRoute = (
             references,
             version,
           } = payloadRule;
-          const finalIndex =
-            outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+          const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
           const idOrRuleIdOrUnknown = id ?? ruleId ?? '(unknown id)';
           try {
             const rule = await updateRules({
diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.ts
index 4842bd1caa5b8..80fdfc1df8e0e 100644
--- a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.ts
+++ b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/update_rules_route.ts
@@ -70,8 +70,7 @@ export const createUpdateRulesRoute = (
           return headers.response().code(404);
         }
 
-        const finalIndex =
-          outputIndex != null ? outputIndex : getIndex(spacesClient.getSpaceId, config);
+        const finalIndex = outputIndex ?? getIndex(spacesClient.getSpaceId, config);
         const rule = await updateRules({
           alertsClient,
           actionsClient,