Skip to content

Commit 64274cc

Browse files
committed
Remove router.navigateToConversationsApp
1 parent c9b6757 commit 64274cc

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

x-pack/plugins/observability_ai_assistant/public/components/chat/chat_header.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ export function ChatHeader({
7373

7474
const handleNavigateToConversations = () => {
7575
if (conversationId) {
76-
router.navigateToConversationsApp('/conversations/{conversationId}', {
76+
router.push('/conversations/{conversationId}', {
7777
path: {
7878
conversationId,
7979
},
8080
query: {},
8181
});
8282
} else {
83-
router.navigateToConversationsApp('/conversations/new', { path: {}, query: {} });
83+
router.push('/conversations/new', { path: {}, query: {} });
8484
}
8585
};
8686

x-pack/plugins/observability_ai_assistant/public/hooks/use_observability_ai_assistant_router.ts

+3-14
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import { PathsOf, TypeAsArgs, TypeOf } from '@kbn/typed-react-router-config';
99
import { useMemo } from 'react';
10-
import { useHistory } from 'react-router-dom';
1110
import { ObservabilityAIAssistantRouter, ObservabilityAIAssistantRoutes } from '../routes/config';
1211
import { observabilityAIAssistantRouter } from '../routes/config';
1312
import { useKibana } from './use_kibana';
@@ -21,15 +20,9 @@ interface StatefulObservabilityAIAssistantRouter extends ObservabilityAIAssistan
2120
path: T,
2221
...params: TypeAsArgs<TypeOf<ObservabilityAIAssistantRoutes, T>>
2322
): void;
24-
navigateToConversationsApp<T extends PathsOf<ObservabilityAIAssistantRoutes>>(
25-
path: T,
26-
...params: TypeAsArgs<TypeOf<ObservabilityAIAssistantRoutes, T>>
27-
): void;
2823
}
2924

3025
export function useObservabilityAIAssistantRouter(): StatefulObservabilityAIAssistantRouter {
31-
const history = useHistory();
32-
3326
const {
3427
services: {
3528
http,
@@ -47,20 +40,16 @@ export function useObservabilityAIAssistantRouter(): StatefulObservabilityAIAssi
4740
...observabilityAIAssistantRouter,
4841
push: (...args) => {
4942
const next = link(...args);
50-
history.push(next);
43+
navigateToApp('observabilityAIAssistant', { path: next, replace: false });
5144
},
5245
replace: (path, ...args) => {
5346
const next = link(path, ...args);
54-
history.replace(next);
55-
},
56-
navigateToConversationsApp: (path, ...args) => {
57-
const next = link(path, ...args);
58-
navigateToApp('observabilityAIAssistant', { path: next, replace: false });
47+
navigateToApp('observabilityAIAssistant', { path: next, replace: true });
5948
},
6049
link: (path, ...args) => {
6150
return http.basePath.prepend('/app/observabilityAIAssistant' + link(path, ...args));
6251
},
6352
}),
64-
[history, navigateToApp, http.basePath]
53+
[navigateToApp, http.basePath]
6554
);
6655
}

0 commit comments

Comments
 (0)