From 4d207ffad809ad887c0c8ada46b78951b68f2885 Mon Sep 17 00:00:00 2001 From: Shahzad Date: Thu, 7 Jan 2021 16:58:39 +0100 Subject: [PATCH] [uptime] Fix tab focus issue for settings page (#87466) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../components/settings/add_connector_flyout.tsx | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx b/x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx index 0637a16da2bb3..f72db03a2363d 100644 --- a/x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx +++ b/x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx @@ -4,7 +4,7 @@ * you may not use this file except in compliance with the Elastic License. */ -import React, { useEffect, useMemo, useState } from 'react'; +import React, { useMemo, useState } from 'react'; import { FormattedMessage } from '@kbn/i18n/react'; import { useDispatch } from 'react-redux'; import { EuiButtonEmpty } from '@elastic/eui'; @@ -31,16 +31,15 @@ export const AddConnectorFlyout = ({ focusInput }: Props) => { const dispatch = useDispatch(); - useEffect(() => { - dispatch(getConnectorsAction.get()); - focusInput(); - }, [addFlyoutVisible, dispatch, focusInput]); - const ConnectorAddFlyout = useMemo( () => getAddConnectorFlyout({ consumer: 'uptime', - onClose: () => setAddFlyoutVisibility(false), + onClose: () => { + dispatch(getConnectorsAction.get()); + setAddFlyoutVisibility(false); + focusInput(); + }, }), // eslint-disable-next-line react-hooks/exhaustive-deps []