diff --git a/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.test.tsx b/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.test.tsx index c182ef8d3ada5..d12ac172b72cd 100644 --- a/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.test.tsx +++ b/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.test.tsx @@ -6,7 +6,7 @@ */ import React from 'react'; import { renderWithReduxStore } from '../../../mocks'; -import { act, screen, waitFor } from '@testing-library/react'; +import { screen, waitFor } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import type { Query, AggregateQuery } from '@kbn/es-query'; import { coreMock } from '@kbn/core/public/mocks'; diff --git a/x-pack/plugins/lens/public/visualizations/xy/types.ts b/x-pack/plugins/lens/public/visualizations/xy/types.ts index 2ac9b3df7fdd2..694799b94638e 100644 --- a/x-pack/plugins/lens/public/visualizations/xy/types.ts +++ b/x-pack/plugins/lens/public/visualizations/xy/types.ts @@ -193,6 +193,18 @@ const areaShared = { }), }; +const lineShared = { + id: 'line', + icon: IconChartLine, + label: i18n.translate('xpack.lens.xyVisualization.lineLabel', { + defaultMessage: 'Line', + }), + sortPriority: 2, + description: i18n.translate('xpack.lens.line.visualizationDescription', { + defaultMessage: 'Reveal variations in data over time.', + }), +}; + export const visualizationSubtypes: VisualizationType[] = [ { id: 'bar', @@ -278,17 +290,7 @@ export const visualizationSubtypes: VisualizationType[] = [ }), ...areaShared, }, - { - id: 'line', - icon: IconChartLine, - label: i18n.translate('xpack.lens.xyVisualization.lineLabel', { - defaultMessage: 'Line', - }), - sortPriority: 2, - description: i18n.translate('xpack.lens.line.visualizationDescription', { - defaultMessage: 'Reveal variations in data over time.', - }), - }, + lineShared, ]; export const visualizationTypes: VisualizationType[] = [ @@ -306,10 +308,7 @@ export const visualizationTypes: VisualizationType[] = [ label: i18n.translate('xpack.lens.xyVisualization.barLabel', { defaultMessage: 'Bar', }), - sortPriority: 1, - description: i18n.translate('xpack.lens.bar.visualizationDescription', { - defaultMessage: 'Compare categories or groups of data via bars.', - }), + ...barShared, getCompatibleSubtype: (seriesType?: string) => { if (seriesType === 'area') { return 'bar'; @@ -342,15 +341,7 @@ export const visualizationTypes: VisualizationType[] = [ }, }, { - id: 'line', - icon: IconChartLine, - label: i18n.translate('xpack.lens.xyVisualization.lineLabel', { - defaultMessage: 'Line', - }), - sortPriority: 2, - description: i18n.translate('xpack.lens.line.visualizationDescription', { - defaultMessage: 'Reveal variations in data over time or categorically.', - }), + ...lineShared, subtypes: ['line'], }, ];