From 41a42555f9a70bfe8f083866f2f38de24c316322 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Fern=C3=A1ndez=20Haro?= Date: Fri, 10 Jan 2025 09:17:40 +0100 Subject: [PATCH] [Cloud Experiments] Flag as private (#206121) --- .github/CODEOWNERS | 4 ++-- docs/developer/plugin-list.asciidoc | 2 +- package.json | 2 +- tsconfig.base.json | 4 ++-- .../cloud_integrations/cloud_experiments/README.mdx | 0 .../cloud_experiments/common/metadata_service/index.ts | 0 .../common/metadata_service/initialize_metadata.ts | 0 .../common/metadata_service/metadata_service.test.ts | 0 .../common/metadata_service/metadata_service.ts | 0 .../common/metadata_service/remove_undefined.ts | 0 .../cloud_integrations/cloud_experiments/jest.config.js | 6 +++--- .../cloud_integrations/cloud_experiments/kibana.jsonc | 4 ++-- .../cloud_integrations/cloud_experiments/public/index.ts | 0 .../cloud_experiments/public/plugin.test.ts | 0 .../cloud_integrations/cloud_experiments/public/plugin.ts | 0 .../cloud_experiments/server/config.test.ts | 0 .../cloud_integrations/cloud_experiments/server/config.ts | 0 .../cloud_integrations/cloud_experiments/server/index.ts | 0 .../cloud_experiments/server/plugin.test.ts | 0 .../cloud_integrations/cloud_experiments/server/plugin.ts | 0 .../cloud_experiments/server/usage/index.ts | 0 .../server/usage/register_usage_collector.test.ts | 0 .../server/usage/register_usage_collector.ts | 0 .../cloud_integrations/cloud_experiments/tsconfig.json | 0 yarn.lock | 2 +- 25 files changed, 12 insertions(+), 12 deletions(-) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/README.mdx (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/common/metadata_service/index.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/common/metadata_service/initialize_metadata.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.test.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/common/metadata_service/remove_undefined.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/jest.config.js (64%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/kibana.jsonc (95%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/public/index.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/public/plugin.test.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/public/plugin.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/config.test.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/config.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/index.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/plugin.test.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/plugin.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/usage/index.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.test.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.ts (100%) rename x-pack/platform/plugins/{shared => private}/cloud_integrations/cloud_experiments/tsconfig.json (100%) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d6399781e050d..f0383e9e556d6 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -830,6 +830,7 @@ x-pack/platform/plugins/private/banners @elastic/appex-sharedux x-pack/platform/plugins/private/canvas @elastic/kibana-presentation x-pack/platform/plugins/private/cloud_integrations/cloud_chat @elastic/kibana-core x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration @elastic/kibana-management +x-pack/platform/plugins/private/cloud_integrations/cloud_experiments @elastic/kibana-core x-pack/platform/plugins/private/cloud_integrations/cloud_full_story @elastic/kibana-core x-pack/platform/plugins/private/cloud_integrations/cloud_links @elastic/kibana-core x-pack/platform/plugins/private/cross_cluster_replication @elastic/kibana-management @@ -865,7 +866,6 @@ x-pack/platform/plugins/shared/aiops @elastic/ml-ui x-pack/platform/plugins/shared/alerting @elastic/response-ops x-pack/platform/plugins/shared/cases @elastic/response-ops x-pack/platform/plugins/shared/cloud @elastic/kibana-core -x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments @elastic/kibana-core x-pack/platform/plugins/shared/dashboard_enhanced @elastic/kibana-presentation x-pack/platform/plugins/shared/data_quality @elastic/obs-ux-logs-team x-pack/platform/plugins/shared/dataset_quality @elastic/obs-ux-logs-team @@ -3252,7 +3252,7 @@ x-pack/platform/plugins/shared/aiops @elastic/ml-ui x-pack/platform/plugins/shared/alerting @elastic/response-ops x-pack/platform/plugins/shared/cases @elastic/response-ops x-pack/platform/plugins/shared/cloud @elastic/kibana-core -x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments @elastic/kibana-core +x-pack/platform/plugins/private/cloud_integrations/cloud_experiments @elastic/kibana-core x-pack/platform/plugins/shared/dashboard_enhanced @elastic/kibana-presentation x-pack/platform/plugins/shared/embeddable_enhanced @elastic/kibana-presentation x-pack/platform/plugins/shared/entity_manager @elastic/obs-entities diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc index 6bdc43e660369..1f90e36cd7ce3 100644 --- a/docs/developer/plugin-list.asciidoc +++ b/docs/developer/plugin-list.asciidoc @@ -496,7 +496,7 @@ It was removed, but the plugin was left behind to register no longer used config |This plugin currently only exists to provide custom fleet policy UX for a set of new BPF LSM features. The first feature being container "drift prevention". -|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/README.mdx[cloudExperiments] +|{kib-repo}blob/{branch}/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/README.mdx[cloudExperiments] |[!NOTE] This plugin no-longer exposes any evaluation APIs. Refer to for more information about how to interact with feature flags. diff --git a/package.json b/package.json index 4fafc5d3a107c..467428ad6404c 100644 --- a/package.json +++ b/package.json @@ -211,7 +211,7 @@ "@kbn/cloud-chat-plugin": "link:x-pack/platform/plugins/private/cloud_integrations/cloud_chat", "@kbn/cloud-data-migration-plugin": "link:x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration", "@kbn/cloud-defend-plugin": "link:x-pack/solutions/security/plugins/cloud_defend", - "@kbn/cloud-experiments-plugin": "link:x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments", + "@kbn/cloud-experiments-plugin": "link:x-pack/platform/plugins/private/cloud_integrations/cloud_experiments", "@kbn/cloud-full-story-plugin": "link:x-pack/platform/plugins/private/cloud_integrations/cloud_full_story", "@kbn/cloud-integration-saml-provider-plugin": "link:x-pack/test/cloud_integration/plugins/saml_provider", "@kbn/cloud-links-plugin": "link:x-pack/platform/plugins/private/cloud_integrations/cloud_links", diff --git a/tsconfig.base.json b/tsconfig.base.json index 73e80dd2759fd..97d73eaa868f5 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -162,8 +162,8 @@ "@kbn/cloud-data-migration-plugin/*": ["x-pack/platform/plugins/private/cloud_integrations/cloud_data_migration/*"], "@kbn/cloud-defend-plugin": ["x-pack/solutions/security/plugins/cloud_defend"], "@kbn/cloud-defend-plugin/*": ["x-pack/solutions/security/plugins/cloud_defend/*"], - "@kbn/cloud-experiments-plugin": ["x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments"], - "@kbn/cloud-experiments-plugin/*": ["x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/*"], + "@kbn/cloud-experiments-plugin": ["x-pack/platform/plugins/private/cloud_integrations/cloud_experiments"], + "@kbn/cloud-experiments-plugin/*": ["x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/*"], "@kbn/cloud-full-story-plugin": ["x-pack/platform/plugins/private/cloud_integrations/cloud_full_story"], "@kbn/cloud-full-story-plugin/*": ["x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/*"], "@kbn/cloud-integration-saml-provider-plugin": ["x-pack/test/cloud_integration/plugins/saml_provider"], diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/README.mdx b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/README.mdx similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/README.mdx rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/README.mdx diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/index.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/index.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/index.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/index.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/initialize_metadata.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/initialize_metadata.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/initialize_metadata.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/initialize_metadata.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.test.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.test.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.test.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.test.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/metadata_service.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/remove_undefined.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/remove_undefined.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/common/metadata_service/remove_undefined.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/common/metadata_service/remove_undefined.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/jest.config.js b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/jest.config.js similarity index 64% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/jest.config.js rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/jest.config.js index 1fc309cf45a17..0d5e10582e82c 100644 --- a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/jest.config.js +++ b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/jest.config.js @@ -8,11 +8,11 @@ module.exports = { preset: '@kbn/test', rootDir: '../../../../../../', - roots: ['/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments'], + roots: ['/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments'], coverageDirectory: - '/target/kibana-coverage/jest/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments', + '/target/kibana-coverage/jest/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments', coverageReporters: ['text', 'html'], collectCoverageFrom: [ - '/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/{common,public,server}/**/*.{ts,tsx}', + '/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/{common,public,server}/**/*.{ts,tsx}', ], }; diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/kibana.jsonc b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/kibana.jsonc similarity index 95% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/kibana.jsonc rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/kibana.jsonc index 8ea0fd75ea553..122553fca3ab7 100644 --- a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/kibana.jsonc +++ b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/kibana.jsonc @@ -5,7 +5,7 @@ "@elastic/kibana-core" ], "group": "platform", - "visibility": "shared", + "visibility": "private", "description": "Provides the necessary APIs to implement A/B testing scenarios, fetching the variations in configuration and reporting back metrics to track conversion rates of the experiments.", "plugin": { "id": "cloudExperiments", @@ -22,4 +22,4 @@ "usageCollection" ] } -} \ No newline at end of file +} diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/public/index.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/public/index.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/public/index.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/public/index.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/public/plugin.test.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/public/plugin.test.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/public/plugin.test.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/public/plugin.test.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/public/plugin.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/public/plugin.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/public/plugin.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/public/plugin.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/config.test.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/config.test.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/config.test.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/config.test.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/config.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/config.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/config.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/config.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/index.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/index.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/index.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/index.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/plugin.test.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/plugin.test.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/plugin.test.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/plugin.test.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/plugin.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/plugin.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/plugin.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/plugin.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/usage/index.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/usage/index.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/usage/index.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/usage/index.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.test.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.test.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.test.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.test.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.ts b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.ts similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.ts rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/server/usage/register_usage_collector.ts diff --git a/x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/tsconfig.json b/x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/tsconfig.json similarity index 100% rename from x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments/tsconfig.json rename to x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/tsconfig.json diff --git a/yarn.lock b/yarn.lock index 906c5e82a7484..2132e341a9a42 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4173,7 +4173,7 @@ version "0.0.0" uid "" -"@kbn/cloud-experiments-plugin@link:x-pack/platform/plugins/shared/cloud_integrations/cloud_experiments": +"@kbn/cloud-experiments-plugin@link:x-pack/platform/plugins/private/cloud_integrations/cloud_experiments": version "0.0.0" uid ""