From 293a70b655f733f73c8b021e88f69bc666f66fc9 Mon Sep 17 00:00:00 2001 From: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Date: Wed, 21 Jun 2023 18:08:13 +0200 Subject: [PATCH] [Lens] small drag and drop visual fixes (#159651) ## Summary Fixes https://github.com/elastic/kibana/issues/159572 1. The dimension element should be invisible when being moved - fixed by `.domDragDrop-isHidden` css below `.domDragDrop--isDragStarted` that was overwriting opacity. before: Screenshot 2023-06-14 at 09 45 23 after: Screenshot 2023-06-14 at 10 01 08 2. When navigating with keyboard, the margin of the element that was moving was slightly off - fixed by changing the constant `REORDER_ITEM_MARGIN` value to 16. Not sure if we use this package somewhere else and I should also test @jughosta? before: Screenshot 2023-06-14 at 09 45 38 after: Screenshot 2023-06-14 at 10 01 16 3. When navigating with keyboard but not reordering, the ghost element was covering completely the element we would drop into. I fixed it by changing the translation values. I think that's not expected? Or is this intentional? before: Screenshot 2023-06-14 at 09 45 47 after: Screenshot 2023-06-14 at 10 01 24 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --- packages/kbn-dom-drag-drop/src/constants.ts | 2 +- packages/kbn-dom-drag-drop/src/drag_drop.test.tsx | 6 +++--- packages/kbn-dom-drag-drop/src/sass/drag_drop.scss | 10 +++++----- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/kbn-dom-drag-drop/src/constants.ts b/packages/kbn-dom-drag-drop/src/constants.ts index e6b211c314048..997d29f517b13 100644 --- a/packages/kbn-dom-drag-drop/src/constants.ts +++ b/packages/kbn-dom-drag-drop/src/constants.ts @@ -8,4 +8,4 @@ export const DEFAULT_DATA_TEST_SUBJ = 'domDragDrop'; export const REORDER_ITEM_HEIGHT = 32; -export const REORDER_ITEM_MARGIN = 8; +export const REORDER_ITEM_MARGIN = 16; diff --git a/packages/kbn-dom-drag-drop/src/drag_drop.test.tsx b/packages/kbn-dom-drag-drop/src/drag_drop.test.tsx index fac4b76f2a33d..1fccf59e49269 100644 --- a/packages/kbn-dom-drag-drop/src/drag_drop.test.tsx +++ b/packages/kbn-dom-drag-drop/src/drag_drop.test.tsx @@ -1100,12 +1100,12 @@ describe('DragDrop', () => { expect( component.find('[data-test-subj="testDragDrop-translatableDrop"]').at(0).prop('style') ).toEqual({ - transform: 'translateY(-4px)', + transform: 'translateY(-8px)', }); expect( component.find('[data-test-subj="testDragDrop-translatableDrop"]').at(1).prop('style') ).toEqual({ - transform: 'translateY(-4px)', + transform: 'translateY(-8px)', }); component @@ -1258,7 +1258,7 @@ describe('DragDrop', () => { expect( component.find('[data-test-subj="testDragDrop-reorderableDrag"]').at(0).prop('style') ).toEqual({ - transform: 'translateY(+4px)', + transform: 'translateY(+8px)', }); expect( component.find('[data-test-subj="testDragDrop-translatableDrop"]').at(0).prop('style') diff --git a/packages/kbn-dom-drag-drop/src/sass/drag_drop.scss b/packages/kbn-dom-drag-drop/src/sass/drag_drop.scss index 56ce648266e7b..fecd5ee6bfbe0 100644 --- a/packages/kbn-dom-drag-drop/src/sass/drag_drop.scss +++ b/packages/kbn-dom-drag-drop/src/sass/drag_drop.scss @@ -15,7 +15,7 @@ width: 100%; left: 0; opacity: .9; - transform: translate($euiSizeXS, $euiSizeXS); + transform: translate($euiSizeS, $euiSizeL); z-index: $domDragDropZLevel3; pointer-events: none; outline: $euiFocusRingSize solid currentColor; // Safari & Firefox @@ -138,6 +138,10 @@ $reorderItemMargin: $euiSizeS; } } +.domDragDrop--isDragStarted { + opacity: .5; +} + // Draggable item when it is moving .domDragDrop-isHidden { opacity: 0; @@ -149,10 +153,6 @@ $reorderItemMargin: $euiSizeS; } } -.domDragDrop--isDragStarted { - opacity: .5; -} - .domDragDrop__extraDrops { opacity: 0; visibility: hidden;