Skip to content

Commit 1f02d07

Browse files
Merge branch 'master' into move-timelion-nav-to-header
2 parents b3436ab + 5858dd8 commit 1f02d07

File tree

660 files changed

+19636
-12648
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

660 files changed

+19636
-12648
lines changed

.github/CODEOWNERS

+8-8
Original file line numberDiff line numberDiff line change
@@ -119,18 +119,18 @@
119119
#CC# /x-pack/plugins/beats_management/ @elastic/beats
120120

121121
# Canvas
122-
/src/plugins/dashboard/ @elastic/kibana-app
123-
/src/plugins/input_control_vis/ @elastic/kibana-app
124-
/src/plugins/vis_type_markdown/ @elastic/kibana-app
122+
/src/plugins/dashboard/ @elastic/kibana-canvas
123+
/src/plugins/input_control_vis/ @elastic/kibana-canvas
124+
/src/plugins/vis_type_markdown/ @elastic/kibana-canvas
125125
/x-pack/plugins/canvas/ @elastic/kibana-canvas
126-
/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-app
126+
/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-canvas
127127
/x-pack/test/functional/apps/canvas/ @elastic/kibana-canvas
128-
#CC# /src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-app
129-
#CC# /src/legacy/core_plugins/input_control_vis @elastic/kibana-app
128+
#CC# /src/legacy/core_plugins/kibana/public/dashboard/ @elastic/kibana-canvas
129+
#CC# /src/legacy/core_plugins/input_control_vis @elastic/kibana-canvas
130130
#CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-canvas
131131
#CC# /x-pack/legacy/plugins/canvas/ @elastic/kibana-canvas
132-
#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-app
133-
#CC# /x-pack/legacy/plugins/dashboard_mode/ @elastic/kibana-app
132+
#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-canvas
133+
#CC# /x-pack/legacy/plugins/dashboard_mode/ @elastic/kibana-canvas
134134

135135
# Core UI
136136
# Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon

.github/ISSUE_TEMPLATE/security_solution_bug_report.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
---
2-
name: Security Solution Bug Report
3-
about: Things break. Help us identify those things so we can fix them!
2+
name: Bug report for Security Solution
3+
about: Help us identify bugs in Elastic Security, SIEM, and Endpoint so we can fix them!
44
title: '[Security Solution]'
5+
labels: Team: SecuritySolution
56
---
67

78
**Describe the bug:**

docs/api/saved-objects.asciidoc

+3
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ The following saved objects APIs are available:
2828

2929
* <<saved-objects-api-resolve-import-errors, Resolve import errors API>> to resolve errors from the import API
3030

31+
* <<saved-objects-api-rotate-encryption-key, Rotate encryption key API>> to rotate the encryption key for encrypted saved objects
32+
3133
include::saved-objects/get.asciidoc[]
3234
include::saved-objects/bulk_get.asciidoc[]
3335
include::saved-objects/find.asciidoc[]
@@ -38,3 +40,4 @@ include::saved-objects/delete.asciidoc[]
3840
include::saved-objects/export.asciidoc[]
3941
include::saved-objects/import.asciidoc[]
4042
include::saved-objects/resolve_import_errors.asciidoc[]
43+
include::saved-objects/rotate_encryption_key.asciidoc[]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
[role="xpack"]
2+
[[saved-objects-api-rotate-encryption-key]]
3+
=== Rotate encryption key API
4+
++++
5+
<titleabbrev>Rotate encryption key</titleabbrev>
6+
++++
7+
8+
experimental[] Rotate the encryption key for encrypted saved objects.
9+
10+
If a saved object cannot be decrypted using the primary encryption key, then {kib} will attempt to decrypt it using the specified <<xpack-encryptedSavedObjects-keyRotation-decryptionOnlyKeys, decryption-only keys>>. In most of the cases this overhead is negligible, but if you're dealing with a large number of saved objects and experiencing performance issues, you may want to rotate the encryption key.
11+
12+
[IMPORTANT]
13+
============================================================================
14+
Bulk key rotation can consume a considerable amount of resources and hence only user with a `superuser` role can trigger it.
15+
============================================================================
16+
17+
[[saved-objects-api-rotate-encryption-key-request]]
18+
==== Request
19+
20+
`POST <kibana host>:<port>/api/encrypted_saved_objects/_rotate_key`
21+
22+
[[saved-objects-api-rotate-encryption-key-request-query-params]]
23+
==== Query parameters
24+
25+
`type`::
26+
(Optional, string) Limits encryption key rotation only to the saved objects with the specified type. By default, {kib} tries to rotate the encryption key for all saved object types that may contain encrypted attributes.
27+
28+
`batchSize`::
29+
(Optional, number) Specifies a maximum number of saved objects that {kib} can process in a single batch. Bulk key rotation is an iterative process since {kib} may not be able to fetch and process all required saved objects in one go and splits processing into consequent batches. By default, the batch size is 10000, which is also a maximum allowed value.
30+
31+
[[saved-objects-api-rotate-encryption-key-response-body]]
32+
==== Response body
33+
34+
`total`::
35+
(number) Indicates the total number of _all_ encrypted saved objects (optionally filtered by the requested `type`), regardless of the key {kib} used for encryption.
36+
37+
`successful`::
38+
(number) Indicates the total number of _all_ encrypted saved objects (optionally filtered by the requested `type`), regardless of the key {kib} used for encryption.
39+
+
40+
NOTE: In most cases, `total` will be greater than `successful` even if `failed` is zero. The reason is that {kib} may not need or may not be able to rotate encryption keys for all encrypted saved objects.
41+
42+
`failed`::
43+
(number) Indicates the number of the saved objects that were still encrypted with one of the old encryption keys that {kib} failed to re-encrypt with the primary key.
44+
45+
[[saved-objects-api-rotate-encryption-key-response-codes]]
46+
==== Response code
47+
48+
`200`::
49+
Indicates a successful call.
50+
51+
`400`::
52+
Indicates that either query parameters are wrong or <<xpack-encryptedSavedObjects-keyRotation-decryptionOnlyKeys, decryption-only keys>> aren't configured.
53+
54+
`429`::
55+
Indicates that key rotation is already in progress.
56+
57+
[[saved-objects-api-rotate-encryption-key-example]]
58+
==== Examples
59+
60+
[[saved-objects-api-rotate-encryption-key-example-1]]
61+
===== Encryption key rotation with default parameters
62+
63+
[source,sh]
64+
--------------------------------------------------
65+
$ curl -X POST /api/encrypted_saved_objects/_rotate_key
66+
--------------------------------------------------
67+
// KIBANA
68+
69+
The API returns the following:
70+
71+
[source,sh]
72+
--------------------------------------------------
73+
{
74+
"total": 1000,
75+
"successful": 300,
76+
"failed": 0
77+
}
78+
--------------------------------------------------
79+
80+
The result indicates that the encryption key was successfully rotated for 300 out of 1000 saved objects with encrypted attributes, and 700 of the saved objects either didn't require key rotation, or were encrypted with an unknown encryption key.
81+
82+
[[saved-objects-api-rotate-encryption-key-example-2]]
83+
===== Encryption key rotation for the specific type with reduce batch size
84+
85+
[IMPORTANT]
86+
============================================================================
87+
Default parameters are optimized for speed. Change the parameters only when necessary. However, if you're experiencing any issues with this API, you may want to decrease a batch size or rotate the encryption keys for the specific types only. In this case, you may need to run key rotation multiple times in a row.
88+
============================================================================
89+
90+
In this example, key rotation is performed for all saved objects with the `alert` type in batches of 5000.
91+
92+
[source,sh]
93+
--------------------------------------------------
94+
$ curl -X POST /api/encrypted_saved_objects/_rotate_key?type=alert&batchSize=5000
95+
--------------------------------------------------
96+
// KIBANA
97+
98+
The API returns the following:
99+
100+
[source,sh]
101+
--------------------------------------------------
102+
{
103+
"total": 100,
104+
"successful": 100,
105+
"failed": 0
106+
}
107+
--------------------------------------------------
108+
109+
The result indicates that the encryption key was successfully rotated for all 100 saved objects with the `alert` type.
110+

docs/developer/best-practices/typescript.asciidoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ This architecture imposes several limitations to which we must comply:
2828
[discrete]
2929
==== Prerequisites
3030
Since project refs rely on generated `d.ts` files, the migration order does matter. You can migrate your plugin only when all the plugin dependencies already have migrated. It creates a situation where commonly used plugins (such as `data` or `kibana_react`) have to migrate first.
31-
https://github.com/elastic/kibana/issues/79343 is going to provide a tool for identifying a plugin dependency tree.
31+
Run `node scripts/find_plugins_without_ts_refs.js --id your_plugin_id` to get a list of plugins that should be switched to TS project refs to unblock your plugin migration.
3232

3333
[discrete]
3434
==== Implementation

docs/developer/plugin-list.asciidoc

+6-11
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,6 @@ which will load the visualization's editor.
286286
|To access an elasticsearch instance that has live data you have two options:
287287
288288
289-
|{kib-repo}blob/{branch}/x-pack/plugins/audit_trail[auditTrail]
290-
|WARNING: Missing README.
291-
292-
293289
|{kib-repo}blob/{branch}/x-pack/plugins/beats_management/readme.md[beatsManagement]
294290
|Notes:
295291
Failure to have auth enabled in Kibana will make for a broken UI. UI-based errors not yet in place
@@ -436,10 +432,8 @@ using the CURL scripts in the scripts folder.
436432
437433
438434
|{kib-repo}blob/{branch}/x-pack/plugins/ml/readme.md[ml]
439-
|To use machine learning features, you must have a Platinum or Enterprise license
440-
or a free 14-day trial. File Data Visualizer requires a Basic license. For more
441-
info, refer to
442-
Set up machine learning features.
435+
|This plugin provides access to the machine learning features provided by
436+
Elastic.
443437
444438
445439
|{kib-repo}blob/{branch}/x-pack/plugins/monitoring[monitoring]
@@ -471,7 +465,8 @@ Set up machine learning features.
471465
472466
473467
|{kib-repo}blob/{branch}/x-pack/plugins/security/README.md[security]
474-
|See Configuring security in Kibana.
468+
|See Configuring security in
469+
Kibana.
475470
476471
477472
|{kib-repo}blob/{branch}/x-pack/plugins/security_solution/README.md[securitySolution]
@@ -501,8 +496,8 @@ routes, etc.
501496
|Gathers all usage collection, retrieving them from both: OSS and X-Pack plugins.
502497
503498
504-
|{kib-repo}blob/{branch}/x-pack/plugins/transform[transform]
505-
|WARNING: Missing README.
499+
|{kib-repo}blob/{branch}/x-pack/plugins/transform/readme.md[transform]
500+
|This plugin provides access to the transforms features provided by Elastic.
506501
507502
508503
|{kib-repo}blob/{branch}/x-pack/plugins/translations[translations]

docs/development/core/server/kibana-plugin-core-server.auditableevent.md

-25
This file was deleted.

docs/development/core/server/kibana-plugin-core-server.auditableevent.message.md

-11
This file was deleted.

docs/development/core/server/kibana-plugin-core-server.auditableevent.type.md

-11
This file was deleted.

docs/development/core/server/kibana-plugin-core-server.auditor.add.md

-36
This file was deleted.

docs/development/core/server/kibana-plugin-core-server.auditor.md

-21
This file was deleted.

docs/development/core/server/kibana-plugin-core-server.auditor.withauditscope.md

-24
This file was deleted.

docs/development/core/server/kibana-plugin-core-server.auditorfactory.asscoped.md

-22
This file was deleted.

docs/development/core/server/kibana-plugin-core-server.auditorfactory.md

-20
This file was deleted.

0 commit comments

Comments
 (0)