Skip to content

Commit 0dda88c

Browse files
committed
Test fix + minor changes
1 parent 1a29cbd commit 0dda88c

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

x-pack/plugins/security_solution/server/lib/detection_engine/signals/send_telemetry_events.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ describe('sendAlertTelemetry', () => {
2929
_source: {
3030
'@timestamp': 'x',
3131
key1: 'hello',
32-
datastream: {
32+
data_stream: {
3333
dataset: 'endpoint.events',
3434
},
3535
},
@@ -42,7 +42,7 @@ describe('sendAlertTelemetry', () => {
4242
_source: {
4343
'@timestamp': 'x',
4444
key2: 'hello',
45-
datastream: {
45+
data_stream: {
4646
dataset: 'endpoint.alerts',
4747
other: 'x',
4848
},
@@ -56,7 +56,7 @@ describe('sendAlertTelemetry', () => {
5656
_source: {
5757
'@timestamp': 'x',
5858
key3: 'hello',
59-
datastream: {},
59+
data_stream: {},
6060
},
6161
},
6262
],
@@ -68,7 +68,7 @@ describe('sendAlertTelemetry', () => {
6868
{
6969
'@timestamp': 'x',
7070
key2: 'hello',
71-
datastream: {
71+
data_stream: {
7272
dataset: 'endpoint.alerts',
7373
other: 'x',
7474
},

x-pack/plugins/security_solution/server/lib/telemetry/sender.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ export class TelemetryEventsSender {
153153
await this.sendEvents(toSend, telemetryUrl, clusterInfo.cluster_uuid, licenseInfo?.uid);
154154
} catch (err) {
155155
this.logger.warn(`Error sending telemetry events data: ${err}`);
156-
// throw err;
157156
this.queue = [];
158157
}
159158
this.isSending = false;
@@ -218,9 +217,11 @@ export class TelemetryEventsSender {
218217
'X-Elastic-Telemetry': '1', // TODO: no longer needed?
219218
},
220219
});
221-
this.logger.debug(`Events sent!. Response: ${resp.status} ${resp.data}`);
220+
this.logger.debug(`Events sent!. Response: ${resp.status} ${JSON.stringify(resp.data)}`);
222221
} catch (err) {
223-
this.logger.warn(`Error sending events: ${err.response.status} ${err.response.data}`);
222+
this.logger.warn(
223+
`Error sending events: ${err.response.status} ${JSON.stringify(err.response.data)}`
224+
);
224225
}
225226
}
226227
}

0 commit comments

Comments
 (0)