From 0a95f5a7c17efa7cd15903aee09679621a56c302 Mon Sep 17 00:00:00 2001 From: Walter Rafelsberger Date: Fri, 4 Feb 2022 17:15:17 +0100 Subject: [PATCH] [ML] Fix tests. Fix i18n. --- .../translations/translations/ja-JP.json | 1 - .../translations/translations/zh-CN.json | 1 - .../permissions/full_transform_access.ts | 9 ++------- .../services/transform/edit_flyout.ts | 17 +++++++++++++++-- 4 files changed, 17 insertions(+), 11 deletions(-) diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index 2d72bd20f7712..1308a05be9ff7 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -25995,7 +25995,6 @@ "xpack.transform.transformList.editFlyoutFormNumberRange10To10000NotValidErrorMessage": "値は10～10000の範囲の整数でなければなりません。", "xpack.transform.transformList.editFlyoutFormRequiredErrorMessage": "必須フィールド。", "xpack.transform.transformList.editFlyoutFormRetentionMaxAgeFieldLabel": "最大年齢", - "xpack.transform.transformList.editFlyoutFormRetentionPolicyButtonContent": "保持ポリシー", "xpack.transform.transformList.editFlyoutFormRetentionPolicyDateFieldHelpText": "デスティネーションインデックスで古いドキュメントを特定するために使用できる日付フィールドを選択します。", "xpack.transform.transformList.editFlyoutFormRetentionPolicyFieldLabel": "フィールド", "xpack.transform.transformList.editFlyoutFormRetentionPolicyFieldSelectAriaLabel": "保持ポリシーを設定する日付フィールド", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index 97f6c16210de8..461da226332e1 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -26456,7 +26456,6 @@ "xpack.transform.transformList.editFlyoutFormNumberRange10To10000NotValidErrorMessage": "值必须是介于 10 到 10000 之间的整数。", "xpack.transform.transformList.editFlyoutFormRequiredErrorMessage": "必填字段。", "xpack.transform.transformList.editFlyoutFormRetentionMaxAgeFieldLabel": "最大存在时间", - "xpack.transform.transformList.editFlyoutFormRetentionPolicyButtonContent": "保留策略", "xpack.transform.transformList.editFlyoutFormRetentionPolicyDateFieldHelpText": "选择可用于从目标索引中识别出日期文档的日期字段。", "xpack.transform.transformList.editFlyoutFormRetentionPolicyFieldLabel": "字段", "xpack.transform.transformList.editFlyoutFormRetentionPolicyFieldSelectAriaLabel": "设置保留策略的日期字段", diff --git a/x-pack/test/functional/apps/transform/permissions/full_transform_access.ts b/x-pack/test/functional/apps/transform/permissions/full_transform_access.ts index 878307ec71996..fe29510e82497 100644 --- a/x-pack/test/functional/apps/transform/permissions/full_transform_access.ts +++ b/x-pack/test/functional/apps/transform/permissions/full_transform_access.ts @@ -154,14 +154,9 @@ export default function ({ getService }: FtrProviderContext) { await transform.editFlyout.assertTransformEditFlyoutIngestPipelineFieldSelectExists(); await transform.testExecution.logTestStep( - 'should have the retention policy inputs enabled' - ); - await transform.editFlyout.openTransformEditAccordionRetentionPolicySettings(); - await transform.editFlyout.assertTransformEditFlyoutRetentionPolicyFieldSelectEnabled(true); - await transform.editFlyout.assertTransformEditFlyoutInputEnabled( - 'RetentionPolicyMaxAge', - true + 'should have the retention policy switch enabled' ); + await transform.editFlyout.assertTransformEditFlyoutRetentionPolicySwitchEnabled(true); await transform.testExecution.logTestStep( 'should have the advanced settings inputs enabled' diff --git a/x-pack/test/functional/services/transform/edit_flyout.ts b/x-pack/test/functional/services/transform/edit_flyout.ts index b2291f91cb3c3..fb1d77f7abc6c 100644 --- a/x-pack/test/functional/services/transform/edit_flyout.ts +++ b/x-pack/test/functional/services/transform/edit_flyout.ts @@ -41,6 +41,19 @@ export function TransformEditFlyoutProvider({ getService }: FtrProviderContext) await testSubjects.existOrFail(`transformEditFlyoutDestinationIngestPipelineFieldSelect`); }, + async assertTransformEditFlyoutRetentionPolicySwitchEnabled(expectedValue: boolean) { + await testSubjects.existOrFail(`transformEditRetentionPolicySwitch`, { + timeout: 1000, + }); + const isEnabled = await testSubjects.isEnabled(`transformEditRetentionPolicySwitch`); + expect(isEnabled).to.eql( + expectedValue, + `Expected 'transformEditRetentionPolicySwitch' input to be '${ + expectedValue ? 'enabled' : 'disabled' + }' (got '${isEnabled ? 'enabled' : 'disabled'}')` + ); + }, + async assertTransformEditFlyoutRetentionPolicyFieldSelectEnabled(expectedValue: boolean) { await testSubjects.existOrFail(`transformEditFlyoutRetentionPolicyFieldSelect`, { timeout: 1000, @@ -100,9 +113,9 @@ export function TransformEditFlyoutProvider({ getService }: FtrProviderContext) await testSubjects.existOrFail('transformEditAccordionAdvancedSettingsContent'); }, - async clickTransformEditRetentionPolicySettings(expectEnabled: boolean) { + async clickTransformEditRetentionPolicySettings(expectExists: boolean) { await testSubjects.click('transformEditRetentionPolicySwitch'); - if (expectEnabled) { + if (expectExists) { await testSubjects.existOrFail('transformEditRetentionPolicyContent'); } else { await testSubjects.missingOrFail('transformEditRetentionPolicyContent');