Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement load averages for Windows #114

Closed
ycombinator opened this issue Apr 9, 2019 · 1 comment
Closed

Implement load averages for Windows #114

ycombinator opened this issue Apr 9, 2019 · 1 comment

Comments

@ycombinator
Copy link

This would help resolve elastic/beats#9944.

Currently, this method is not implemented:

gosigar/sigar_windows.go

Lines 57 to 59 in 7bed239

func (self *LoadAverage) Get() error {
return ErrNotImplemented{runtime.GOOS}
}

This is likely because the analogous function in the C Sigar library is also not implemented:

https://github.com/hyperic/sigar/blob/ad47dc3b494e9293d1f087aebb099bdba832de5e/src/os/win32/win32_sigar.c#L1140-L1149

However, https://github.com/boundary/sigar, which is a fork of https://github.com/hyperic/sigar has an implementation for the above function:

https://github.com/boundary/sigar/blob/a6c61edf8c64e013411e8c9d753165cd03102c6e/src/os/win32/win32_sigar.c#L1084-L1125

Perhaps we could reference this implementation and port it over?

Related: #107

@ycombinator ycombinator changed the title Implement load average for Windows Implement load averages for Windows Apr 10, 2019
@cachedout
Copy link

@ycombinator Per our discussion yesterday, I am going to close this. Let me know if you think that's incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants