Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiCollapsibleNav and EuiCollapsibleNavGroup #6865

Merged
merged 13 commits into from
Jun 23, 2023
Merged

[Emotion] Convert EuiCollapsibleNav and EuiCollapsibleNavGroup #6865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eb8e07d
Convert EuiCollapsibleNav to Emotion
cee-chen Jun 20, 2023
dbd06eb
[EuiCollapsibleNavGroup] Set up base Emotion styles
cee-chen Jun 20, 2023
e069e93
[EuiCollapsibleNavGroup] Convert `background` prop to Emotion
cee-chen Jun 20, 2023
e24431a
Remove unused focus animation
cee-chen Jun 21, 2023
88f0237
Remove unused font-weight
cee-chen Jun 21, 2023
c0586ad
Convert remaining padding CSS
cee-chen Jun 21, 2023
86118b5
Delete all Sass files
cee-chen Jun 21, 2023
796ef7d
Convert Enzyme tests to RTL
cee-chen Jun 21, 2023
0f49c0c
[docs] Remove now-unnecessary `EuiThemeProvider` from collapsible nav…
cee-chen Jun 21, 2023
eebcabf
Set up Storybooks
cee-chen Jun 21, 2023
c3ced8c
Add full pattern storybook demo
cee-chen Jun 21, 2023
bd1d1ad
changelog
cee-chen Jun 22, 2023
71bb4b8
Revert "Add full pattern storybook demo"
cee-chen Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions src-docs/src/views/collapsible_nav/collapsible_nav_all.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import { KibanaNavLinks, SecurityGroup } from './collapsible_nav_list';

import contentSvg from '../../images/content.svg';
import { useExitPath } from '../../services/routing/routing';
import { EuiThemeProvider } from '../../../../src/services';

const TopLinks: EuiPinnableListGroupItemProps[] = [
{
Expand Down Expand Up @@ -161,23 +160,21 @@ const CollapsibleNavAll = () => {
{/* Dark deployments section */}
<EuiFlexItem grow={false} style={{ flexShrink: 0 }}>
<EuiCollapsibleNavGroup isCollapsible={false} background="dark">
<EuiThemeProvider colorMode="dark">
<EuiListGroup
maxWidth="none"
gutterSize="none"
size="s"
listItems={[
{
label: 'Manage deployment',
href: '#',
iconType: 'logoCloud',
iconProps: {
color: 'ghost',
},
<EuiListGroup
maxWidth="none"
gutterSize="none"
size="s"
listItems={[
{
label: 'Manage deployment',
href: '#',
iconType: 'logoCloud',
iconProps: {
color: 'ghost',
},
]}
/>
</EuiThemeProvider>
},
]}
/>
</EuiCollapsibleNavGroup>
</EuiFlexItem>

Expand Down
11 changes: 3 additions & 8 deletions src-docs/src/views/collapsible_nav/collapsible_nav_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {
import { EuiSpacer } from '../../../../src/components/spacer';
import { EuiButton, EuiButtonIcon } from '../../../../src/components/button';
import { EuiLink } from '../../../../src/components/link';
import { EuiThemeProvider } from '../../../../src/services';

const deploymentsList: EuiListGroupProps['listItems'] = [
{
Expand Down Expand Up @@ -62,13 +61,9 @@ export const DeploymentsGroup = (
initialIsOpen={false}
background="dark"
>
<div role="group" className="kibanaNavDeployment__content">
<EuiThemeProvider colorMode="dark">
<EuiListGroup listItems={deploymentsList} flush />
<EuiSpacer size="s" />
<EuiButton fullWidth>Manage deployments</EuiButton>
</EuiThemeProvider>
</div>
<EuiListGroup listItems={deploymentsList} flush />
<EuiSpacer size="s" />
<EuiButton fullWidth>Manage deployments</EuiButton>
</EuiCollapsibleNavGroup>
);

Expand Down
Loading