[EuiDataGrid] Add title attribute to column header cell content
#6013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to make headings more visible if text is being truncated due to column widths
- clarify props documentation for `displayAsText` - reorder props by general purpose - Update `columns` snippet to include all props and also to follow new grouping order
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6013/ |
- reproducible on the Version column in the main datagrid example
cee-chen
changed the title
title attribute to column header cellstitle attribute to column header cell text
cee-chen
changed the title
title attribute to column header cell texttitle attribute to column header cell content
|
I did some testing on VO and it turns out leaving the In any case, putting the |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6013/ |
chandlerprall
approved these changes
Jun 30, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #6012
This uses
displayAsTextby default, falling back toid(which meanstitleshould always be present).Checklist
and playground togglesjest and cypress testssnapshots- [ ] Checked in both light and dark modes- [ ] Checked in mobile- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Updated the Figma library counterpart