From 710ee28f58a356983c411d37d7f2756232ac4a09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A1udia=20Correia?= Date: Tue, 10 May 2022 11:23:48 +0100 Subject: [PATCH 1/4] Center enter badge in combo box option --- .../combo_box/combo_box_options_list/_combo_box_option.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/combo_box/combo_box_options_list/_combo_box_option.scss b/src/components/combo_box/combo_box_options_list/_combo_box_option.scss index 9f7f68ce90f..5ff6415f704 100644 --- a/src/components/combo_box/combo_box_options_list/_combo_box_option.scss +++ b/src/components/combo_box/combo_box_options_list/_combo_box_option.scss @@ -38,7 +38,7 @@ } .euiComboBoxOption__enterBadge { - align-self: flex-start; + align-self: center; margin-left: $euiSizeXS; } } From 0a4c3f7941609162f7b77573cd1ba947bd39dc52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A1udia=20Correia?= Date: Tue, 10 May 2022 15:21:15 +0100 Subject: [PATCH 2/4] Add changelog --- upcoming_changelogs/5890.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 upcoming_changelogs/5890.md diff --git a/upcoming_changelogs/5890.md b/upcoming_changelogs/5890.md new file mode 100644 index 00000000000..0adb5891b2a --- /dev/null +++ b/upcoming_changelogs/5890.md @@ -0,0 +1,3 @@ +**Bug fixes** + +- Fixed `EuiComboBox` by centering the enter badge in the list options. From 272e4a4ddef2fa6b849ae678c995e42c6edc400a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A1udia=20Correia?= Date: Mon, 16 May 2022 12:48:21 +0100 Subject: [PATCH 3/4] Add margin-block to EuiComboBoxOptionsList CSS --- .../combo_box_options_list/_combo_box_options_list.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss b/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss index b61c19f104b..8034adea7be 100644 --- a/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss +++ b/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss @@ -10,6 +10,10 @@ &.euiPopover__panel-isAttached.euiComboBoxOptionsList--top { /* 1 */ @include euiBottomShadowFlat; } + + .euiFilterSelectItem__content { + margin-block: 0 !important; + } } .euiComboBoxOptionsList__empty { From 7f5be4dcb86e4c8b64ae6156d146ca9979aa7c53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A1udia=20Correia?= Date: Tue, 17 May 2022 17:40:26 +0100 Subject: [PATCH 4/4] Disable sass-lint no-important warning --- .../combo_box_options_list/_combo_box_options_list.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss b/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss index 8034adea7be..58b194a8fe1 100644 --- a/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss +++ b/src/components/combo_box/combo_box_options_list/_combo_box_options_list.scss @@ -12,6 +12,7 @@ } .euiFilterSelectItem__content { + // sass-lint:disable no-important margin-block: 0 !important; } }