-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Playground] EuiCodeEditor #3935
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3935/ |
This looks out-of-date with master (doesn't have the new docgen info). Can you please update? |
Done . |
jenkins test this |
|
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3935/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value
and onChange
are missing type info. Might need to merge master again.
Also, because theme
and mode
require imports, even if a user enters a valid value they will get errors. What do you think about importing more theme and mode options and adding a note below the input to hint at what sample values are available?
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3935/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That works well.
Summary
Makes progress on #3057
Checklist