Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Playground] EuiTab #3910

Merged
merged 3 commits into from
Aug 18, 2020
Merged

[Playground] EuiTab #3910

merged 3 commits into from
Aug 18, 2020

Conversation

anishagg17
Copy link
Contributor

Summary

Makes progress on #3057

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3910/

thompsongl
thompsongl reviewed Aug 14, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anishagg17 Can you make sure this (and other playground PRs) are up to date with master? The new docgen script could have some __docgenInfo differences that could cause object value chaining issues.

@anishagg17
Copy link
Contributor Author

@anishagg17 Can you make sure this (and other playground PRs) are up to date with master? The new docgen script could have some __docgenInfo differences that could cause object value chaining issues.

Yes, sure.

@anishagg17 anishagg17 requested a review from thompsongl August 14, 2020 20:30
@thompsongl
Copy link
Contributor

Of course, I told you to merge master when master was broken 🤦

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3910/

@thompsongl thompsongl merged commit 635ceb1 into elastic:master Aug 18, 2020
@anishagg17 anishagg17 deleted the play_tab branch August 18, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anishagg17 @kibanamachine @thompsongl