From ccbbd0447c2787af2a267497a195add56666ca2e Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Thu, 11 Jan 2018 14:38:32 -0800 Subject: [PATCH 1/3] Z-index for toasts --- src/components/toast/_toast.scss | 1 + src/global_styling/variables/_z_index.scss | 1 + 2 files changed, 2 insertions(+) diff --git a/src/components/toast/_toast.scss b/src/components/toast/_toast.scss index f2452e5d18f..b4ce37875e8 100644 --- a/src/components/toast/_toast.scss +++ b/src/components/toast/_toast.scss @@ -6,6 +6,7 @@ background-color: $euiColorEmptyShade; border: $euiBorderThin; width: 100%; + z-index: $euiZToast; &:hover .euiToast__closeButton, &:focus .euiToast__closeButton, { diff --git a/src/global_styling/variables/_z_index.scss b/src/global_styling/variables/_z_index.scss index 3b7048e0b7d..6d4fa3049a2 100644 --- a/src/global_styling/variables/_z_index.scss +++ b/src/global_styling/variables/_z_index.scss @@ -17,3 +17,4 @@ $euiZNavigation: $euiZLevel4; $euiZToastList: $euiZLevel5; $euiZMask: $euiZLevel6; $euiZModal: $euiZLevel8; +$euiZToast: $euiZLevel9; From 112d1a1d36f65bb2b9b8fad9cc2a4551f26c1206 Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Thu, 11 Jan 2018 14:41:07 -0800 Subject: [PATCH 2/3] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6d40d567e3c..dcce2f2ea94 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ **Bug fixes** +- Adjust toast z-index to show over modals [(#296)](https://github.com/elastic/eui/pull/296) - Removed padding on `` mobile breakpoint. [(#282)](https://github.com/elastic/eui/pull/282) - Fixed some `` `type`s not setting their `viewBox` attribute, which caused them to not honor the `size` properly. [(#277)](https://github.com/elastic/eui/pull/277) - Fixed `` to pass the `event` argument to a ``'s `onClick` handler even when a panel is defined. [(#265)](https://github.com/elastic/eui/pull/265) From e617f99086d97224321bd63c53956e7c74934b6a Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Thu, 11 Jan 2018 14:43:33 -0800 Subject: [PATCH 3/3] apply to list instead --- src/components/toast/_toast.scss | 1 - src/global_styling/variables/_z_index.scss | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/toast/_toast.scss b/src/components/toast/_toast.scss index b4ce37875e8..f2452e5d18f 100644 --- a/src/components/toast/_toast.scss +++ b/src/components/toast/_toast.scss @@ -6,7 +6,6 @@ background-color: $euiColorEmptyShade; border: $euiBorderThin; width: 100%; - z-index: $euiZToast; &:hover .euiToast__closeButton, &:focus .euiToast__closeButton, { diff --git a/src/global_styling/variables/_z_index.scss b/src/global_styling/variables/_z_index.scss index 6d4fa3049a2..00e45d1d197 100644 --- a/src/global_styling/variables/_z_index.scss +++ b/src/global_styling/variables/_z_index.scss @@ -14,7 +14,6 @@ $euiZLevel9: 9000; $euiZContent: $euiZLevel0; $euiZContentMenu: $euiZLevel2; $euiZNavigation: $euiZLevel4; -$euiZToastList: $euiZLevel5; $euiZMask: $euiZLevel6; $euiZModal: $euiZLevel8; -$euiZToast: $euiZLevel9; +$euiZToastList: $euiZLevel9;