From 302d21cd0c378590ce8f7f9af91426f3a85e19bb Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Mon, 23 Sep 2019 16:27:48 -0400 Subject: [PATCH 1/8] use for EuiFacetButton :focus --- src/components/facet/_facet_button.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/facet/_facet_button.scss b/src/components/facet/_facet_button.scss index 886d6f26d00..12cce9ea348 100644 --- a/src/components/facet/_facet_button.scss +++ b/src/components/facet/_facet_button.scss @@ -25,7 +25,7 @@ } &:focus { - background-color: $euiColorLightestShade; + background-color: $euiFocusBackgroundColor; } &:disabled { From 81336b0410a78692076eed14d710d8f947bc9458 Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Wed, 25 Sep 2019 15:50:51 -0400 Subject: [PATCH 2/8] added package.js + package.svg --- src/components/icon/assets/package.js | 14 ++++++++++++++ src/components/icon/assets/package.svg | 3 +++ 2 files changed, 17 insertions(+) create mode 100644 src/components/icon/assets/package.js create mode 100644 src/components/icon/assets/package.svg diff --git a/src/components/icon/assets/package.js b/src/components/icon/assets/package.js new file mode 100644 index 00000000000..4c00763c0c7 --- /dev/null +++ b/src/components/icon/assets/package.js @@ -0,0 +1,14 @@ +import React from 'react'; + +const EuiIconPackage = props => ( + + + +); + +export const icon = EuiIconPackage; diff --git a/src/components/icon/assets/package.svg b/src/components/icon/assets/package.svg new file mode 100644 index 00000000000..66028ab53d8 --- /dev/null +++ b/src/components/icon/assets/package.svg @@ -0,0 +1,3 @@ + + + From 677cc60ba90ae68c91b1bd4b5358502044ca212c Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Wed, 25 Sep 2019 15:57:08 -0400 Subject: [PATCH 3/8] added icon reference to icon.tsx and src-docs/.../icon.js --- src/components/icon/icon.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/icon/icon.tsx b/src/components/icon/icon.tsx index 08b887484f7..0b4d41ef2b6 100644 --- a/src/components/icon/icon.tsx +++ b/src/components/icon/icon.tsx @@ -238,6 +238,7 @@ const typeToPathMap = { number: 'number', offline: 'offline', online: 'online', + package: 'package', packetbeatApp: 'app_packetbeat', partial: 'partial', pause: 'pause', From 46ed1872d63f6b3dbec058f3de23a4c0cfc7a3d7 Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Wed, 25 Sep 2019 17:10:40 -0400 Subject: [PATCH 4/8] update package icon --- src-docs/src/views/icon/icons.js | 1 + .../icon/__snapshots__/icon.test.tsx.snap | 15 +++++++++++++++ src/components/icon/assets/package.js | 2 +- src/components/icon/assets/package.svg | 6 +++--- 4 files changed, 20 insertions(+), 4 deletions(-) diff --git a/src-docs/src/views/icon/icons.js b/src-docs/src/views/icon/icons.js index 3607ee0e95f..0974dd159ed 100644 --- a/src-docs/src/views/icon/icons.js +++ b/src-docs/src/views/icon/icons.js @@ -127,6 +127,7 @@ const iconTypes = [ 'number', 'offline', 'online', + 'package', 'partial', 'pause', 'pencil', diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index f1b6bda4f82..486890d0120 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -5058,6 +5058,21 @@ exports[`EuiIcon props type online is rendered 1`] = ` `; +exports[`EuiIcon props type package is rendered 1`] = ` + + + +`; + exports[`EuiIcon props type packetbeatApp is rendered 1`] = ` ( viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" {...props}> - + ); diff --git a/src/components/icon/assets/package.svg b/src/components/icon/assets/package.svg index 66028ab53d8..51b96f7f9e7 100644 --- a/src/components/icon/assets/package.svg +++ b/src/components/icon/assets/package.svg @@ -1,3 +1,3 @@ - - - + + + \ No newline at end of file From 228951bb28617cce063648187286b1a58cdfd0bf Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Wed, 25 Sep 2019 17:24:07 -0400 Subject: [PATCH 5/8] updated changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f7a296c8b8..2b811b90f30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Added `package` icon to glyph set ([#2378](https://github.com/elastic/eui/pull/2378)) - Modified `EuiFacetButton` to use `$euiFocusBackgroundColor` for `:focus` state ([2365](https://github.com/elastic/eui/pull/2365)) - Added a `showMaxPopover` option for `EuiBreadcrumbs` to display all items when a `max` is set. ([#2342](https://github.com/elastic/eui/pull/2342)) - Added `data-test-subj` support for basic and in-memory tables' actions ([#2353](https://github.com/elastic/eui/pull/2353)) From fda9d1e51ef5e0aca9ddc0dc4d0950afdf105020 Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Wed, 25 Sep 2019 17:38:26 -0400 Subject: [PATCH 6/8] fixed svg viewbox --- src/components/icon/assets/package.svg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/icon/assets/package.svg b/src/components/icon/assets/package.svg index 51b96f7f9e7..892f32c016e 100644 --- a/src/components/icon/assets/package.svg +++ b/src/components/icon/assets/package.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file From 68107dd7ba972aaa091245666dcb34ecbb65c28e Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Thu, 26 Sep 2019 10:56:35 -0400 Subject: [PATCH 7/8] update package icon --- src/components/icon/assets/package.js | 2 +- src/components/icon/assets/package.svg | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/icon/assets/package.js b/src/components/icon/assets/package.js index 944b99088d9..f92c8b02e2f 100644 --- a/src/components/icon/assets/package.js +++ b/src/components/icon/assets/package.js @@ -7,7 +7,7 @@ const EuiIconPackage = props => ( viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" {...props}> - + ); diff --git a/src/components/icon/assets/package.svg b/src/components/icon/assets/package.svg index 892f32c016e..8ec479e0157 100644 --- a/src/components/icon/assets/package.svg +++ b/src/components/icon/assets/package.svg @@ -1,3 +1,3 @@ - - + + \ No newline at end of file From 1ab967e0535913a272ad505495d28853602beb7a Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Thu, 26 Sep 2019 11:17:54 -0400 Subject: [PATCH 8/8] updated icon test snapshot --- src/components/icon/__snapshots__/icon.test.tsx.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index cd2adab2ea6..2a95d870ab9 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -5068,7 +5068,7 @@ exports[`EuiIcon props type package is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `;