Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTabs] Remove xl size #8302

Open
ryankeairns opened this issue Jan 31, 2025 · 0 comments
Open

[EuiTabs] Remove xl size #8302

ryankeairns opened this issue Jan 31, 2025 · 0 comments

Comments

@ryankeairns
Copy link
Contributor

Discussed in #8128

Originally posted by ryankeairns November 10, 2024
Two reasons for this request:

  1. Subjectively, it is an atypical font size for tabs (see below)[a].
  2. Objectively, we don't use it in Kibana [b]

[a] The guidelines say to only use for page titles only, but I don't believe this is a justifiable recommendation.
[b] Search for usage with this regex <EuiTabs[ \w=\{\}>\(\)\n;".-:]* size="xl"

Note: I suppose this would be a breaking change for anyone out there is using it (seem unlikely; low impact), and we could suggest using l as the recommended fix.

CleanShot 2024-11-10 at 21 51 08@2x

@ryankeairns ryankeairns changed the title [EuiTabs] Remove 'xl' size [EuiTabs] Remove xl size Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant