Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services should be exported at the main export #694

Closed
bevacqua opened this issue Apr 23, 2018 · 2 comments
Closed

Services should be exported at the main export #694

bevacqua opened this issue Apr 23, 2018 · 2 comments

Comments

@bevacqua
Copy link
Contributor

Today, we access services via '@elastic/eui/lib/services'. This isn't ideal, as it forces consumers to remember the path, ties the interface up to internal implementation details (directory structure), and murks the distinction between what constitutes public interface and the EUI implementation.

We should expose services such as the htmlIdGenerator function at the top level, so that it can be imported just like any component:

import {
  EuiButton,
  EuiText,
  htmlIdGenerator,
} from '@elastic/eui'
@bevacqua
Copy link
Contributor Author

cc @cjcenizal

@chandlerprall
Copy link
Contributor

Services have been exposed to the top level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants