Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade unified to latest v10.x #6602

Closed
watson opened this issue Feb 15, 2023 · 4 comments
Closed

Upgrade unified to latest v10.x #6602

watson opened this issue Feb 15, 2023 · 4 comments

Comments

@watson
Copy link
Contributor

watson commented Feb 15, 2023

We're in the process of upgrading the unified package in Kibana (PR: elastic/kibana#151276). However to not run two different versions of unified in Kibana we prefer if we could upgrade this package in EUI first (source). Then we'll wait with our upgrade until a new version of EUI with the upgraded package is released.

@cee-chen
Copy link
Contributor

cee-chen commented Feb 15, 2023

@watson is this something you're asking the EUI team to do, or is this a contribution you could help make to the EUI repo? My concern here is that I've previously investigated generally upgrading remark-related plugins to v9/v10+ and unfortunately it appears that they switched to ESM in 10.x+, making upgrading a non-trivial task: #5543 (comment)

We simply don't have the team or bandwidth right now to significantly update EuiMarkdownEditor's plugins as a resulting change of this upgrade. We would certainly accept a PR from another team however!

@cee-chen
Copy link
Contributor

cee-chen commented Feb 15, 2023

I'm continuing the conversation in the linked Kibana thread (elastic/kibana#151276), as that has more context as to full scope and motivation of the request. In the interim I'm closing this issue as a duplicate of #5543.

@watson
Copy link
Contributor Author

watson commented Feb 16, 2023

Sorry - I wasn't aware that upgrading would be such a huge workload. I didn't know exactly what these packages was being used for, but looking at their changelog I figured it wouldn't be hard. Fine with closing this issue 👍

@cee-chen
Copy link
Contributor

All good! I thought that too in my original investigation, and got somewhat far (working imports/types etc.), until it came time to open up EuiMarkdownEditor and the entire component was broken 😅 To be honest, it may not be a bad idea in the future for another team (e.g. within Kibana) to take over the markdown editor completely, which would include rewriting it with remark/unified v10+ at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants