Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox: Retain focus on input as you traverse the options with the keyboard #589

Closed
cjcenizal opened this issue Mar 28, 2018 · 1 comment · Fixed by #1258
Closed
Assignees

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 28, 2018

Per #567 (comment):

I think we should separate the up/down selection from the input focus. Right now you can't move up and down and type at the same time. I think you want to keep the cursor focused in the input as they move up and down. I know that means you don't get the benefit of auto-scrolling because of the item focus, but having them as separate actions means your hands need to do much less work to move around. With the aria stuff I think you'd have to read the selection independently, but you can see the benefit there too, since it will read the first match as you type.

Tied to that, I'd auto-select the first option so you can just jam on enter immediately. As mentioned before, should also help speed up a screen reader's time to action as well.

We can implement this by applying a "focused" class to the option instead of using actual browser focus. We'd have to implement some logic to scroll the list to the new active option.

@chandlerprall
Copy link
Contributor

chandlerprall commented Oct 5, 2018

Related to #1195 , the fix for which is to keep focus in the combobox's input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants