Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eui table selection doesnt work in the last version #5145

Closed
lior-fortifieddata opened this issue Sep 5, 2021 · 2 comments · Fixed by #5150
Closed

Eui table selection doesnt work in the last version #5145

lior-fortifieddata opened this issue Sep 5, 2021 · 2 comments · Fixed by #5150
Assignees
Labels

Comments

@lior-fortifieddata
Copy link

lior-fortifieddata commented Sep 5, 2021

the table selection doesn't work anymore
you may look at the examples page, and try to check/uncheck:

https://elastic.github.io/eui/#/tabular-content/tables#adding-selection-to-a-table

@cchaos
Copy link
Contributor

cchaos commented Sep 6, 2021

🙌 Wow, thanks for this find. It looks like this was caused by #5130 whereby the clip makes the underlying checkbox input un-clickable.

@constancecchen Can you please take a look? We may want to do a quick revert of that PR as it's now a problem with any checkbox that doesn't have a label.

@cee-chen
Copy link
Contributor

cee-chen commented Sep 7, 2021

Thanks a ton for the ping Caroline, and awesome catch on this @lior-fortifieddata! I should be able to have a fix for this in a few hours here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants