Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTab] Add option for secondary content like EuiNotificationBadge #5057

Closed
cchaos opened this issue Aug 20, 2021 · 0 comments · Fixed by #5135
Closed

[EuiTab] Add option for secondary content like EuiNotificationBadge #5057

cchaos opened this issue Aug 20, 2021 · 0 comments · Fixed by #5135
Assignees

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 20, 2021

image

so one thing I noticed about this non-centering issue - I believe that when the button is hovered, an underline shows up both for the button copy and for the number within the EuiNotificationBadge, and the number appears centered when the underline is visible. I was unable to remove the underline with any of the usual css tricks - something to keep in mind!

Originally posted by @ecezalp in #4992 (comment)


Yep because you're putting the badge inside of a button which gets text-decoration: underline on :hover. There's no way to separate out the button content vs non-button content from the consuming side. Usually you can add text-decoration: none !important to the part you don't want to get the attribute.

But I've also seen this pattern emerging more often (notification badge inside a tab) and maybe one we can implement as part of the EuiTab itself.

Originally posted by @cchaos in #4992 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant