Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFilterGroup] Rebuild multi-select demo using EuiSelectable #3735

Closed
myasonik opened this issue Jul 13, 2020 · 1 comment · Fixed by #5387
Closed

[EuiFilterGroup] Rebuild multi-select demo using EuiSelectable #3735

myasonik opened this issue Jul 13, 2020 · 1 comment · Fixed by #5387
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@myasonik
Copy link
Contributor

The existing EuiFilterGroup multi-select demo has a few a11y shortcomings and differs in implementation from EuiSelectable which has been crowned as the future implementation of dropdown-like things. To consolidate implementations of similar components, fix the a11y problems, and unify the UX, EuiFilterGroup should be rewritten using EuiSelectable.

On top of EuiSelectable, EuiFilterGroup's multi-select largely provides:

  1. A custom button that open a popover (inside which EuiSelectable would/could live)

I think the EUI team prefers to keep the EuiComoboBox component and to wrap EuiSelectable within it but another implementation option is to add a "renderAs" prop (or something along those lines) to EuiSelectable to adjust styling.

@myasonik myasonik added accessibility accessibility - WCAG A Level A WCAG Accessibility Criteria labels Jul 13, 2020
@cchaos cchaos changed the title Rebuild [EuiFilterGroup] multi-select demo with EuiSelectable [EuiFilterGroup] Rebuild multi-select demo using EuiSelectable Sep 20, 2020
@cchaos cchaos added assign:anyone documentation Issues or PRs that only affect documentation - will not need changelog entries labels Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants