-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiTabs can break layouts #3373
Comments
Ah. I see the issue now. |
This is not a problem with the tabs themselves, but the container. Essentially, because of the flex, you'll need to make sure you have a You can fix this on the docs by applying the following @cchaos can you see any downside to applying |
@snide the same issue happens on this page: https://elastic.github.io/eui/#/display/code. I think it was introduced with the Applying |
@snide's fix seems beautiful |
Looks good Dave, thanks! So is this something you (eui team) would apply to the Meaning, should we (cloud) fix it, or wait for an eui level fix, then upgrade? |
I don't see a reason not to add this to EUI itself |
I'll make a PR for @cchaos to review. |
Summary
When you have a number of EuiTabs, they do not honour the width of their parent and instead force their own width. This can lead to weird behaviour on smaller screens.
Here's an example of the Elastic Cloud layout being forced to horizontal scroll.
and here's how it affects the EUI docs themselves.
Here's a related issue filed in Elastic Cloud https://github.com/elastic/cloud/issues/46807
The text was updated successfully, but these errors were encountered: