-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Grid] Cell focus is too aggressive #2208
Comments
How set are you on #3? The rest I agree are buggy things in my implementation but that was intentional. It's not spelled out in the spec so I don't think we strictly have to keep it that way but every example did keep with that so, so did I. I think the workflow that it enables is: I'm doing something in the grid, I realize I need to change a setting or something, and then I want to come back to what I'm doing. If focus resets in that case, I have to navigate back to the cell where I was working instead of being able to pick up with where I was. I'm sure there's some other workflow that's negatively impacted because there always is but nothing concrete comes to mind. |
This was fixed in our feature branch. Thanks @myasonik |
This seems to have resurfaced in the version we have merged into EUI so I'm reopening the issue. |
To me, three doesn’t seem like a problem, perhaps if necessary |
I think this ticket has become a little broad and confusing. What I was talking about resurfacing is on page load, the grid steals focus immediately. (Focus should be on first focusable element of the page almost always.) Everything else (including number 3 in the description) works as expected right now, I believe. |
@myasonik can you test again when you get a chance? I'm not reproducing the auto-focus issue. |
Can't reproduce it anymore! Closing this ticket! |
The cell focus in use in
EuiDataGrid
is a little too eager at the moment. We likely need the following usage changes.The text was updated successfully, but these errors were encountered: