Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclamation mark in circle icon #2121

Closed
markov00 opened this issue Jul 15, 2019 · 3 comments
Closed

Exclamation mark in circle icon #2121

markov00 opened this issue Jul 15, 2019 · 3 comments

Comments

@markov00
Copy link
Member

For the TSVB chart replacement we are also going to replace existing fa font awesome charts. We have one icon missing: an exclamation mark within a circle

Screenshot 2019-07-15 at 16 46 16

It will be great to have this icon before 7.4 feature freeze

@markov00 markov00 changed the title Exclamation mark in Circle Exclamation mark in circle icon Jul 15, 2019
@cchaos
Copy link
Contributor

cchaos commented Jul 15, 2019

If this is an absolute must and it can't be substituted for the triangle version, I'd say this is a special use-case and make it a custom icon in Kibana (specifically TSVB).

@markov00
Copy link
Member Author

So the problem here is that a TSVB visualization can be saved with either the exclamation circle and the exclamation triangle when adding an annotation. If the user rely (rare case but possible) on those two different icons we can have a some issues if they are using those two icons together and we replace all those icons with the same one.
Screenshot 2019-07-15 at 17 30 44
Screenshot 2019-07-15 at 17 31 37

@cchaos
Copy link
Contributor

cchaos commented Jul 15, 2019

That's fine, then we will want this as a custom icon living only in TSVB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants