Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alignment and distribution icons #2067

Closed
ryankeairns opened this issue Jun 20, 2019 · 2 comments · Fixed by #2070
Closed

Add alignment and distribution icons #2067

ryankeairns opened this issue Jun 20, 2019 · 2 comments · Fixed by #2070
Assignees
Labels

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Jun 20, 2019

Canvas has a current need for such icons (PR - elastic/kibana#39132) and it sounds like Lens could also use them.

The set would be similar to those found in Sketch:

Screenshot 2019-06-20 13 14 26

Align
left | center | right | top | middle | bottom

Corner position
top left | top right | bottom left | bottom right

Distribute
horizontal | vertical

@ryankeairns ryankeairns self-assigned this Jun 20, 2019
@ryankeairns
Copy link
Contributor Author

How does this make you feel?

1px padding around each; the center and middle have 2px pad along one side to make the one-pixel bar intersect precisely at center of the rounded rectangle (which is 1px shorter in these two cases).

Preview

Screenshot 2019-06-20 15 37 04

Sketch pixel grid

Screenshot 2019-06-20 15 40 56

@cchaos
Copy link
Contributor

cchaos commented Jun 20, 2019

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants