Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperDatePicker] Assess test coverage #1918

Closed
flash1293 opened this issue May 6, 2019 · 6 comments
Closed

[EuiSuperDatePicker] Assess test coverage #1918

flash1293 opened this issue May 6, 2019 · 6 comments
Labels
testing Issues or PRs that only affect tests - will not need changelog entries

Comments

@flash1293
Copy link
Contributor

flash1293 commented May 6, 2019

During the last releases Kibana had quite a few bugs around date handling and time zones (configured and system).

Because of this we tried to identify parts of Kibana which should be tested more thoroughly to improve the situation. One step is improving the unit test coverage (especially test around handling different time zones) of relevant components, super date picker included.

From a quick look at the coverage reports it looks like there are some tests missing although it doesn't seem to be a big deal.

Screenshot 2019-05-06 at 10 04 08

What's your feeling about this? Are there tests missing around super date picker?

Ping @bhavyarm @markov00 @timroes

@chandlerprall
Copy link
Contributor

We are 100% missing these tests, thank you for bringing this up!

I had a discussion a few weeks ago with @bhavyarm and either Marius or Dzmitry about super date picker jest tests (unit & functional). It was decided the majority of tests should live in EUI and the QA team was going to start putting those together, with help from myself if/when requested.

@flash1293
Copy link
Contributor Author

Awesome, let me know if I can help somehow.

@bhavyarm
Copy link
Contributor

bhavyarm commented May 6, 2019

@marius-dr @dmlemeshko

@marius-dr
Copy link
Member

Yep, I had a look at writing the more tests for it. National holidays kinda messed up my schedule, but now I'm trying to get some in by GAH, or at least in the first week after.

@snide snide added the testing Issues or PRs that only affect tests - will not need changelog entries label May 8, 2019
@cchaos cchaos changed the title Assess super_date_picker test coverage [EuiSuperDatePicker] Assess test coverage Mar 18, 2020
@snide snide mentioned this issue Mar 9, 2021
41 tasks
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@cee-chen
Copy link
Contributor

cee-chen commented Apr 3, 2023

Closing this as not planned due to the age of the issue and lack of team prioritization. We'd happily welcome a contribution/PR on this however.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Development

No branches or pull requests

7 participants