-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSuperDatePicker] Assess test coverage #1918
Comments
We are 100% missing these tests, thank you for bringing this up! I had a discussion a few weeks ago with @bhavyarm and either Marius or Dzmitry about super date picker jest tests (unit & functional). It was decided the majority of tests should live in EUI and the QA team was going to start putting those together, with help from myself if/when requested. |
Awesome, let me know if I can help somehow. |
Yep, I had a look at writing the more tests for it. National holidays kinda messed up my schedule, but now I'm trying to get some in by GAH, or at least in the first week after. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
Closing this as not planned due to the age of the issue and lack of team prioritization. We'd happily welcome a contribution/PR on this however. |
During the last releases Kibana had quite a few bugs around date handling and time zones (configured and system).
Because of this we tried to identify parts of Kibana which should be tested more thoroughly to improve the situation. One step is improving the unit test coverage (especially test around handling different time zones) of relevant components, super date picker included.
From a quick look at the coverage reports it looks like there are some tests missing although it doesn't seem to be a big deal.
What's your feeling about this? Are there tests missing around super date picker?
Ping @bhavyarm @markov00 @timroes
The text was updated successfully, but these errors were encountered: