Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove inline callouts in JDBC docs for Asciidoctor migration #41266

Merged
merged 1 commit into from
Apr 22, 2019
Merged

[DOCS] Remove inline callouts in JDBC docs for Asciidoctor migration #41266

merged 1 commit into from
Apr 22, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 16, 2019

Removes inline callouts from the SQL JDBC documentation page.

Per https://asciidoctor.org/docs/user-manual/#callouts, AsciiDoctor enforces this requirement: "The callout number (at the target) must be placed at the end of the line."

Relates to #41128

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@jrodewig jrodewig merged commit 25d81c1 into elastic:master Apr 22, 2019
@jrodewig jrodewig deleted the fix-asciidoctor-errors-jbdc branch April 22, 2019 13:07
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants