-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Replace nested open block for Asciidoctor migration #41168
[DOCS] Replace nested open block for Asciidoctor migration #41168
Conversation
Pinging @elastic/es-docs |
If the table renders well I'm happy with it. I know we usually use definition lists because tables tend to come out poorly when we try to use them for this sort of thing. |
Thanks for the feedback @nik9000. Here's a screenshot from my local build: I agree that tables generally aren't preferred, but I couldn't figure out a way to nest a definition list and still stay Asciidoctor valid. Please feel free to leave a suggestion or point me the right way if I'm overlooking something though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks fine to me!
Another possible solution that seems to work for me is this:
|
Thanks for the solve @lcawl. Pushed c5b9aa2 to reformat the table to a definition list. I feel much better about this without a table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and builds successfully
* [DOCS] Fix nested open blocks for Asciidoctor migration * [DOCS] Reformat table to definitions
* [DOCS] Fix nested open blocks for Asciidoctor migration * [DOCS] Reformat table to definitions
…1168) * [DOCS] Fix nested open blocks for Asciidoctor migration * [DOCS] Reformat table to definitions
Per asciidoctor/asciidoctor#1121, Asciidoctor does not currently allow nested open blocks. This removes the nested open block from the Index modules page and replaces it with a table.
This prevents the following error:
INFO:build_docs:asciidoctor: ERROR: illegal block content outside of partintro block
Relates to #41128