Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix callout for Asciidoctor migration #41129

Merged
merged 1 commit into from
Apr 11, 2019
Merged

[DOCS] Fix callout for Asciidoctor migration #41129

merged 1 commit into from
Apr 11, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 11, 2019

Per https://asciidoctor.org/docs/user-manual/#callouts, AsciiDoctor enforces this requirement: "The callout number (at the target) must be placed at the end of the line."

This prevents the following error:
INFO:build_docs:asciidoctor: WARNING: query-dsl/script-score-query.asciidoc: line 109: no callout found for <1>

Relates to #41128

@jrodewig jrodewig requested review from nik9000 and lcawl April 11, 2019 19:25
@jrodewig jrodewig added :Docs >docs General docs changes labels Apr 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 391ac5a into elastic:master Apr 11, 2019
@jrodewig jrodewig deleted the fix-asciidoctor-errors branch April 11, 2019 19:51
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants