Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially addressing bbq bwc failures and added logging #122553

Merged
merged 6 commits into from
Feb 18, 2025
Merged

Potentially addressing bbq bwc failures and added logging #122553

merged 6 commits into from
Feb 18, 2025

Conversation

benwtrent
Copy link
Member

I have ran this many times locally, and it never failed. Maybe there is something "magical" in CI.

Added some additional info in the assertion logging.

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests :Search Relevance/Vectors Vector search v9.0.0 v8.18.1 v8.19.0 v9.1.0 labels Feb 13, 2025
@benwtrent benwtrent changed the title Addressing bbq bwc failures Potentially addressing bbq bwc failures and added logging Feb 14, 2025
@benwtrent benwtrent marked this pull request as ready for review February 14, 2025 16:11
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Feb 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

john-wagster
john-wagster approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Feb 18, 2025
@elasticsearchmachine elasticsearchmachine merged commit 894db68 into elastic:main Feb 18, 2025
17 checks passed
@benwtrent benwtrent deleted the test/fix-bbq-bwc branch February 18, 2025 16:46
This was referenced Feb 21, 2025
Merged
Merged
Merged
@benwtrent
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 9.0
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Feb 21, 2025
@benwtrent
Potentially addressing bbq bwc failures and added logging (elastic#12…
44cee92 
…2553)

I have ran this many times locally, and it never failed. Maybe there is
something "magical" in CI.

Added some additional info in the assertion logging.

(cherry picked from commit 894db68)
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Feb 21, 2025
@benwtrent
Potentially addressing bbq bwc failures and added logging (elastic#12…
9c6b174 
…2553)

I have ran this many times locally, and it never failed. Maybe there is
something "magical" in CI.

Added some additional info in the assertion logging.

(cherry picked from commit 894db68)
elasticsearchmachine pushed a commit that referenced this pull request Feb 21, 2025
@benwtrent
Potentially addressing bbq bwc failures and added logging (#122553) (#…
d643e3c 
…123140)

I have ran this many times locally, and it never failed. Maybe there is
something "magical" in CI.

Added some additional info in the assertion logging.

(cherry picked from commit 894db68)
elasticsearchmachine pushed a commit that referenced this pull request Feb 21, 2025
@benwtrent
Potentially addressing bbq bwc failures and added logging (#122553) (#…
b81add7 
…123143)

I have ran this many times locally, and it never failed. Maybe there is
something "magical" in CI.

Added some additional info in the assertion logging.

(cherry picked from commit 894db68)
benwtrent added a commit that referenced this pull request Feb 21, 2025
@benwtrent
Potentially addressing bbq bwc failures and added logging (#122553) (#…
93df6c1 
…123142)

I have ran this many times locally, and it never failed. Maybe there is
something "magical" in CI.

Added some additional info in the assertion logging.

(cherry picked from commit 894db68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-wagster john-wagster john-wagster approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benwtrent @elasticsearchmachine @john-wagster