ESQL: Grow heap attack tests #121714
Merged
ESQL: Grow heap attack tests #121714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures. Closes elastic#121465
nik9000
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
idegtiarenko
reviewed
Feb 5, 2025
| attempt++; | ||
| } catch (ResponseException e) { | ||
| Map<?, ?> map = responseAsMap(e.getResponse()); | ||
| logger.info("expected circuit breaker {}", map); |
There was a problem hiding this comment.
This is expected, I wonder if we should log it at all...
May be it is wroth adding attempt here if we decide to log it anyway.
There was a problem hiding this comment.
Yeah, it really isn't worth it. We get it from the assertion bit if there's a failure.
idegtiarenko
reviewed
Feb 5, 2025
| while (attempt <= MAX_ATTEMPTS) { | ||
| try { | ||
| Map<String, Object> response = tryBreaking.attempt(attempt); | ||
| logger.error("{}: should circuit broken but got {}", attempt, response); |
There was a problem hiding this comment.
Lets change it to warn since it is retryable.
idegtiarenko
reviewed
Feb 5, 2025
| } | ||
| } | ||
| fail("giving up circuit breaking after " + attempt + " attempts"); | ||
| } |
idegtiarenko
approved these changes
Feb 5, 2025
|
run elasticsearch-ci/part-1 |
|
@elasticsearchmachine, run elasticsearch-ci/part-1 |
💔 Backport failed
You can use sqren/backport to manually backport by running |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 5, 2025
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures. Closes elastic#121465
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 5, 2025
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures. Closes elastic#121465
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 5, 2025
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures. Closes elastic#121465
nik9000
added a commit
that referenced
this pull request
Feb 5, 2025
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures. Closes #121465
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures. Closes #121465
nik9000
added a commit
that referenced
this pull request
Feb 6, 2025
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures. Closes #121465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes the ESQL heap attack tests to grow their memory usage if they first don't cause a circuit breaking exception. It just tries again with more data. That's slow, but it should stop this from failing quite as much. And it'll give us even more information about failures.
Closes #121465