-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indices Exists API missing include_type_name in REST API spec #43905
Comments
Pinging @elastic/es-search |
The parameter exists in the indices.get API already, they both map to the same REST action. Although the response body for the HEAD request used for checking existence is empty, the parameter can be used to avoid deprecation warnings and should be added so clients that generate their API from the rest spec pick it up. Closes elastic#43905
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes elastic#43905
…c#43963) Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes elastic#43905
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
@russcam instead of adding the parameter to the indices.exist API, we decided to rather prevent the deprecation log for the exists API (see discussion in #43910 and fix in #43963). Just backporting this to 6.8 now, if we do another minor release on that branch that might help the user. It doesn't really make sense to have this parameter in this API since the body is empty. Let me know if this you think this solved the issue or if we are missing something. |
…c#43963) Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes elastic#43905
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
Removing the deprecation warning for index.exists is a much better solution. Thanks for the fix @cbuescher 👍 |
Issue
Relates: elastic/elasticsearch-net#3901
The REST API spec for indices.exists.json is missing
include_type_name
in 6.8.0:elasticsearch/rest-api-spec/src/main/resources/rest-api-spec/api/indices.exists.json
Lines 16 to 42 in 1263279
Sending an index exists request without
include_type_name
results in a Deprecation Warning HTTP header being returned:Request
Response
Sending a request with
include_type_name=true
orinclude_type_name=false
results in no Deprecation Warning.Feature
The indices.exists.json REST API spec should include
include_type_name
in the list of params, so that clients that generate API methods from the spec pick this up.The text was updated successfully, but these errors were encountered: