Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Deprecation warnings cause failures for 2 tests in MixedClusterClientYamlTestSuiteIT in 6.8 #42796

Closed
dimitris-athanasiou opened this issue Jun 3, 2019 · 4 comments
Closed

[CI] Deprecation warnings cause failures for 2 tests in MixedClusterClientYamlTestSuiteIT in 6.8 #42796

dimitris-athanasiou opened this issue Jun 3, 2019 · 4 comments
Assignees
@dnhatn
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >test-failure Triaged test failures from CI v6.8.0

Comments

@dimitris-athanasiou
Copy link
Contributor

Build link: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.8+bwc-tests/112/console

Two tests failed:

Reproduce 1:

./gradlew :qa:mixed-cluster:v5.6.0#mixedClusterTestRunner -Dtests.seed=50C77143AD9C6ABC -Dtests.class=org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT -Dtests.method="test {p0=update/11_shard_header/Update check shard header}" -Dtests.security.manager=true -Dtests.locale=es-CL -Dtests.timezone=Asia/Atyrau -Dcompiler.java=12 -Druntime.java=8

Failure 1:

FAILURE 0.30s | MixedClusterClientYamlTestSuiteIT.test {p0=update/11_shard_header/Update check shard header} <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: Failure at [update/11_shard_header:23]: got unexpected warning header [
   > 	299 Elasticsearch-6.8.1-SNAPSHOT-8c087df "Usage of internal versioning for optimistic concurrency control is deprecated and will be removed. Please use the `if_seq_no` and `if_primary_term` parameters instead. (request for index [foobar], type [baz], id [1])"
   > ]
   > 	at __randomizedtesting.SeedInfo.seed([50C77143AD9C6ABC:D8934E9903600744]:0)
   > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:412)
   > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:389)
   > 	at java.lang.Thread.run(Thread.java:748)
   > Caused by: java.lang.AssertionError: got unexpected warning header [
   > 	299 Elasticsearch-6.8.1-SNAPSHOT-8c087df "Usage of internal versioning for optimistic concurrency control is deprecated and will be removed. Please use the `if_seq_no` and `if_primary_term` parameters instead. (request for index [foobar], type [baz], id [1])"
   > ]
   > 	at org.elasticsearch.test.rest.yaml.section.DoSection.checkWarningHeaders(DoSection.java:330)
   > 	at org.elasticsearch.test.rest.yaml.section.DoSection.execute(DoSection.java:258)
   > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:405)
   > 	... 37 more

Reproduce 2:

REPRODUCE WITH: ./gradlew :qa:mixed-cluster:v5.6.0#mixedClusterTestRunner -Dtests.seed=50C77143AD9C6ABC -Dtests.class=org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT -Dtests.method="test {p0=update/60_refresh/refresh=wait_for waits until changes are visible in search}" -Dtests.security.manager=true -Dtests.locale=es-CL -Dtests.timezone=Asia/Atyrau -Dcompiler.java=12 -Druntime.java=8

Failure 2:

FAILURE 1.16s | MixedClusterClientYamlTestSuiteIT.test {p0=update/60_refresh/refresh=wait_for waits until changes are visible in search} <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: Failure at [update/60_refresh:99]: got unexpected warning header [
   > 	299 Elasticsearch-6.8.1-SNAPSHOT-8c087df "Usage of internal versioning for optimistic concurrency control is deprecated and will be removed. Please use the `if_seq_no` and `if_primary_term` parameters instead. (request for index [update_60_refresh_1], type [test], id [update_60_refresh_id1])"
   > ]
   > 	at __randomizedtesting.SeedInfo.seed([50C77143AD9C6ABC:D8934E9903600744]:0)
   > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:412)
   > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:389)
   > 	at java.lang.Thread.run(Thread.java:748)
   > Caused by: java.lang.AssertionError: got unexpected warning header [
   > 	299 Elasticsearch-6.8.1-SNAPSHOT-8c087df "Usage of internal versioning for optimistic concurrency control is deprecated and will be removed. Please use the `if_seq_no` and `if_primary_term` parameters instead. (request for index [update_60_refresh_1], type [test], id [update_60_refresh_id1])"
   > ]
   > 	at org.elasticsearch.test.rest.yaml.section.DoSection.checkWarningHeaders(DoSection.java:330)
   > 	at org.elasticsearch.test.rest.yaml.section.DoSection.execute(DoSection.java:258)
   > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:405)
   > 	... 37 more

I could not reproduce the first but I do reproduce the second reliably on my machine.
@dimitris-athanasiou dimitris-athanasiou added >test-failure Triaged test failures from CI :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.8.0 labels Jun 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch
Copy link
Contributor

ywelsch commented Jun 3, 2019

@dnhatn is working on a fix here: #42641

@dimitris-athanasiou
Copy link
Contributor Author

These also failed in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.8+default-distro-bwc-tests/98/console with the same error:

org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT test {p0=update/10_doc/Partial document}
org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT test {p0=update/12_result/Update result field}
org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT test {p0=update/20_doc_upsert/Doc upsert}
org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT test {p0=update/22_doc_as_upsert/Doc as upsert}
org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT test {p0=update/40_routing/Routing}
org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT test {p0=update/60_refresh/When refresh url parameter is an empty string that means "refresh immediately"}

It seems to be the same underlying issue.

@dnhatn dnhatn mentioned this issue Jun 4, 2019
Merged
dnhatn added a commit that referenced this issue Jun 5, 2019
@dnhatn
Move CAS deprecation to TransportShardBulkAction (#42641)
88767a2 
If the primary on 6.6+ but replicas on older versions, we can not use
CAS using ifSeqNo since it requires all nodes on 6.6+. In this case, we
have to fall back to use CAS with _version and should not issue a
deprecation warning log during validation. This change moves the CAS
deprecation to TransportShardBulkAction so we can have the cluster
information to determine if we should log deprecation.

Closes #42796
Relates #42596
@dnhatn
Copy link
Member

dnhatn commented Jun 5, 2019

Fixed in #42641

@dnhatn dnhatn closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >test-failure Triaged test failures from CI v6.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ywelsch @dimitris-athanasiou @dnhatn @elasticmachine