Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bwc state loading logic in MetaStateService #38557

Closed
martijnvg opened this issue Feb 7, 2019 · 2 comments
Closed

Remove bwc state loading logic in MetaStateService #38557

martijnvg opened this issue Feb 7, 2019 · 2 comments
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.0.0-alpha1

Comments

@martijnvg
Copy link
Member

As part of preparing master for 8.0 (#38514), the assertions were disabled in MetaStateService#loadFullStateBWC(...) were disabled.

In an effort to make 8.0 build pass quickly, however looking at this issue, besides removing the mentioned method and loading just an empty manifest if there is none, also some tests need to change. For example RecoveryWithUnsupportedIndicesIT#testUpgradeStartClusterOn_2_4_5, I think it should now try to load a 5.x index?

This bwc logic was added via #35049.
@martijnvg martijnvg added :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.0.0 labels Feb 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

martijnvg added a commit to jasontedor/elasticsearch that referenced this issue Feb 7, 2019
@martijnvg
Comment out asserts, and remove bwc logic later elastic#38557
8b537b9
@martijnvg
Copy link
Member Author

Closing in favor of #38556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martijnvg @jakelandis @elasticmachine