jvmStats does not handle java.lang.InternalError

[GorillaCoder]

jvmStats catches Exception. It should be catching Exception|java.lang.InternalError. As is noted in the comment in the code, MemoryPoolMXBean throws InternalError, and InternalError is not derived from Exception:

            } catch (Exception ex) {
                /* ignore some JVMs might barf here with:
                 * java.lang.InternalError: Memory Pool not found
                 * we just omit the pool in that case!*/
            }

[jasontedor]

Are you seeing this in practice? I think this is only a stale comment from when we use to catch throwable in the entire codebase. We have removed that, we do not catch fatal errors that we can not recover from. The Javadocs for MemoryPoolMXBean do not document an InternalError.

Relates #19231

[elasticmachine]

Pinging @elastic/es-core-infra

[masseyke]

Relates to #95710. We've seen that InternalError at least twice in our CI system (out of probably tens of thousands of runs). So I've put in a catch for the InternalError.