-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unloadable indices feature #24269
Comments
@m31collision i suggest opening a PR here and marking as WIP, otherwise nobody will see it |
@clintongormley created #24357, lets try |
Of course PR has been closed because it is made for 2.3. I cant do patch for master because it changed a lot relative to 2.3 version. Any ideas? |
@m31collision we're not going to merge anything but important bug fixes into 2.x, so the only way forward is to target master. |
Also, you may want to outline your approach in this issue before submitting a huge PR |
yes, I know, but what did you mean by this:
I said that currently I dont have patch for master. But I expected that you (developers) will do some analyze of my patch and give notes because I dont know this project well. Well, it remains to me to do this patch for master. |
I'm closing this for now since it looks like this is going to be opened as a PR again. Feel free to reopen or add an outline of your suggested approach here. |
Hello guys!
I want to propose you implementation for unloadable indices feature. This issue implements what has been requested and discussed in #10869, #23546.
I opened separate pull request (m31collision#1) in forked repo, please, have a look. Of cource, it is not ready for pulling here and it is implemented for 2.3 version only because we use mainly this version on our prods. It is not used on prod yet, only tests.
It has durty code without tests, but I need to know - is it acceptable for you for further development? It seems to me this implementation has no shortcomings mentioned in those issues.
Thanks.
The text was updated successfully, but these errors were encountered: