-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the maximum queue_size for fixed thread pools? #14448
Comments
I thinks makes sense. |
there is another issue I closed lately related to this: #3890 |
but hey we maybe should do both.... Lets just do 1024 and be done with it |
+1 on at least setting an upper bound. have seen quite a few cases in the field where users have set queue sizes to unlimited or some ridiculous number like 1 million+ |
If you set the queue size to less than 0 on a fixed thread pool you'll get an unbounded queue. |
Closed in favor of #18613 |
Dynamically adjustable
queue_size
s for thread pools can in general be a useful feature for users to tune depending on their cluster utilization. However, asqueue_size
tends toInteger.MAX_VALUE
, the value of this turns negative. So perhaps we should set a upper bound onqueue_size
beyond which it can not be set?Relates #11511, relates #14367 (cf. comment from @dakrone)
The text was updated successfully, but these errors were encountered: