Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the maximum queue_size for fixed thread pools? #14448

Closed
jasontedor opened this issue Nov 2, 2015 · 6 comments
Closed

Limit the maximum queue_size for fixed thread pools? #14448

jasontedor opened this issue Nov 2, 2015 · 6 comments
Labels
:Core/Infra/Core Core issues without another label good first issue low hanging fruit help wanted adoptme resiliency

Comments

@jasontedor
Copy link
Member

Dynamically adjustable queue_sizes for thread pools can in general be a useful feature for users to tune depending on their cluster utilization. However, as queue_size tends to Integer.MAX_VALUE, the value of this turns negative. So perhaps we should set a upper bound on queue_size beyond which it can not be set?

Relates #11511, relates #14367 (cf. comment from @dakrone)

@bleskes
Copy link
Contributor

bleskes commented Nov 4, 2015

I thinks makes sense.

@s1monw
Copy link
Contributor

s1monw commented Nov 6, 2015

there is another issue I closed lately related to this: #3890
I think we can do much better by computing some sensible limit based on the throughput and make that the default?

@s1monw
Copy link
Contributor

s1monw commented Nov 6, 2015

but hey we maybe should do both.... Lets just do 1024 and be done with it

@ppf2
Copy link
Member

ppf2 commented Nov 14, 2015

+1 on at least setting an upper bound. have seen quite a few cases in the field where users have set queue sizes to unlimited or some ridiculous number like 1 million+

@clintongormley clintongormley added good first issue low hanging fruit help wanted adoptme :Core/Infra/Core Core issues without another label and removed :Core/Infra/Settings Settings infrastructure and APIs discuss labels Jan 29, 2016
@nik9000
Copy link
Member

nik9000 commented May 20, 2016

If you set the queue size to less than 0 on a fixed thread pool you'll get an unbounded queue.

@jasontedor
Copy link
Member Author

Closed in favor of #18613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label good first issue low hanging fruit help wanted adoptme resiliency
Projects
None yet
Development

No branches or pull requests

6 participants