Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move heatmap onBrushEnd callback to Settings #1214

Closed
markov00 opened this issue Jun 22, 2021 · 0 comments · Fixed by #1369
Closed

Move heatmap onBrushEnd callback to Settings #1214

markov00 opened this issue Jun 22, 2021 · 0 comments · Fixed by #1369
Assignees
@rshen91
Labels
breaking change bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:Medium :interactions Interactions related issue

Comments

@markov00
Copy link
Member

The onBrushEnd action usually is configured in the Settings component.
For the Heatmap instead, the callback is wrongly configured in the config.

We should replace the config.onBrushEnd with the default Settings.onBrushend one.
@markov00 markov00 added bug Something isn't working :interactions Interactions related issue breaking change :heatmap Heatmap/Swimlane chart related issue labels Jun 22, 2021
@markov00 markov00 mentioned this issue Jun 22, 2021
Merged
12 tasks
@rshen91 rshen91 self-assigned this Sep 9, 2021
@rshen91 rshen91 mentioned this issue Sep 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
breaking change bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:Medium :interactions Interactions related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(heatmap): move onBrushEnd from config to Settings rshen91/elastic-charts
2 participants
@markov00 @rshen91