Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default volumes in podTemplate overrides #3187

Closed
sebgl opened this issue Jun 4, 2020 · 2 comments
Closed

Disable default volumes in podTemplate overrides #3187

sebgl opened this issue Jun 4, 2020 · 2 comments

Comments

@sebgl
Copy link
Contributor

sebgl commented Jun 4, 2020

Forked from the Beat CRD PR (#3041 (comment)).
I don't think we have a way for the user to override a volume so it isn't appended by default. Which may be useful for metricbeat or filebeat, if you don't want to mount /proc or /var/log/containers for example.

@sebgl sebgl added the discuss We need to figure this out label Jun 4, 2020
@botelastic botelastic bot added the triage label Jun 4, 2020
@sebgl sebgl removed the triage label Jun 4, 2020
@botelastic botelastic bot added the triage label Jun 4, 2020
@david-kow
Copy link
Contributor

As user podTemplate is applied first and not overwritten I think the below should work (not tested though):

volumes:
- name: proc
  emptyDir: {}

Seems hacky, so some alternatives:

  1. flag to prevent adding default volumes
  2. list field of default volume names to exclude
  3. don't use default volumes if the user provides a config

@david-kow
Copy link
Contributor

As we decided to go with no defaults approach, this is no longer an issue. Closing.

@thbkrkr thbkrkr added >non-issue and removed triage discuss We need to figure this out labels Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants