Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Enforce validation on namespace #20693

Closed
ph opened this issue Aug 19, 2020 · 8 comments
Closed

[Elastic Agent] Enforce validation on namespace #20693

ph opened this issue Aug 19, 2020 · 8 comments
Assignees

Comments

@ph
Copy link
Contributor

ph commented Aug 19, 2020

In Kibana we are adding validation on top of the namespace to remove the possibility to create invalid index name.
We should have the same rules applied on the elastic-agent.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@michalpristas
Copy link
Contributor

should be done at configuration parse time:

func matchesIndexContraints(namespace string) bool {

@ph
Copy link
Contributor Author

ph commented Aug 24, 2020

@michalpristas Can you confirm that the validation match between Kibana and the Agent?

@michalpristas
Copy link
Contributor

i will verify what they are using, we took rules from ES documentation so if they did the same we should be fine. i will confirm

@michalpristas
Copy link
Contributor

michalpristas commented Aug 25, 2020

the validation rules used in kibana is more relaxed I left a comment there in a PR https://github.com/elastic/kibana/pull/75381/files#r476228944 and created issue to align elastic/kibana#75846

@ph
Copy link
Contributor Author

ph commented Aug 25, 2020

@michalpristas I think both are incorrect, see my comment in https://github.com/elastic/kibana/pull/75381/files#r476416054 Can you take a lead and synchronize with @jen-huang to have unique validation for both?

@jen-huang
Copy link

I followed up in elastic/kibana#75846 (comment).

@michalpristas
Copy link
Contributor

Closing, fixed by #21406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants