Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] libbeat refactorings and cleanup #11816

Closed
2 tasks
simitt opened this issue Apr 15, 2019 · 1 comment
Closed
2 tasks

[Meta] libbeat refactorings and cleanup #11816

simitt opened this issue Apr 15, 2019 · 1 comment

Comments

@simitt
Copy link
Contributor

simitt commented Apr 15, 2019

As discussed with @urso this meta issue should be used to collect improvements for libbeat that exceed the scope of cleanup within other PRs. The meta issue should help identifying where code improvements are necessary and not forget about them.

  • Get rid of using NewBeat returning a half initialized beat, in favor of NewInitializedBeat that ensures full initialization before returning the beat. NewInitializedBeat loads the beat config file and panics if this config is not available. Tests need to be updated to work with the initialization as unit tests by default don't provide the config file. Moreover NewBeat is an exported method, so it should only be deprecated until the next major version upgrade. Reference: Refactor export and idxmgmt handling. #11777 (comment)
  • Evaluate and use Elastic's Golang Elasticsearch client instead of ours: https://github.com/elastic/go-elasticsearch
@simitt
Copy link
Contributor Author

simitt commented May 28, 2020

Closing this issue, as it didn't get updated with new issues and doesn't seem useful.

@simitt simitt closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant