Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup work for 8.0.0 #10773

Closed
1 task
kaiyan-sheng opened this issue Feb 15, 2019 · 7 comments
Closed
1 task

Cleanup work for 8.0.0 #10773

kaiyan-sheng opened this issue Feb 15, 2019 · 7 comments
Labels
discuss Issue needs further discussion. meta Team:Integrations Label for the Integrations team

Comments

@kaiyan-sheng
Copy link
Contributor

This issue is to track all the cleanup work needs to be done before 8.0.0. Please feel free to add items into this list.

  • Dedot docker and k8s labels/annotations by default
@kaiyan-sheng kaiyan-sheng added meta Team:Integrations Label for the Integrations team discuss Issue needs further discussion. labels Feb 15, 2019
@jsoriano
Copy link
Member

Dedot docker and k8s labels/annotations by default

I think the plan was to do it in 7.0, wasn't it done? 😬

@jsoriano
Copy link
Member

I think the plan was to do it in 7.0, wasn't it done? grimacing

Replying to myself, yes, it seems to be set to true by default. @kaiyan-sheng is dedotting missing in some place?

@kaiyan-sheng
Copy link
Contributor Author

@jsoriano Yes it's done for 7.0. Do we need to remove the dedot option in 8.0?

@jsoriano
Copy link
Member

I think we can keep it, in case someone doesn't want dedotting.

@kaiyan-sheng
Copy link
Contributor Author

Maybe I should close this issue :-)

@exekias
Copy link
Contributor

exekias commented Apr 23, 2019

+1 to keep the feature, we just ship we the right defaults :)

@kaiyan-sheng
Copy link
Contributor Author

Yeah, I will close this for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs further discussion. meta Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

3 participants