Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docker apm-server.yml management #1553

Closed
graphaelli opened this issue Nov 14, 2018 · 0 comments · Fixed by #1956
Closed

improve docker apm-server.yml management #1553

graphaelli opened this issue Nov 14, 2018 · 0 comments · Fixed by #1956
Assignees

Comments

@graphaelli
Copy link
Member

graphaelli commented Nov 14, 2018

#1543 introduced apm-server.docker.yml into the repo. We need to ensure that there is no drift between that and apm-server.yml, except where needed to support docker more naturally. Some options:

  • generate apm-server.docker.yml during packaging
  • add tests that only permit known difference between apm-server.yml and apm-server.docker.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants