Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws exception when parsing 'BacnetAddress' structure with broadcast mac address #113

Closed
LADSoft opened this issue Oct 11, 2022 · 1 comment

Comments

@LADSoft
Copy link
Contributor

LADSoft commented Oct 11, 2022

I tried to read someone's notification class recipient list and had a problem with that. Basically, they had stuck a by address record in with a broadcast mac address. I looked and the spec specifically allows for this; basically an empty byte array in the MAC address field is considered to be a broadcast address. (FWIW this same record also had the broadcast network address of 0xffff)

The ASN1 decoding for context tags threw an exception on this... 'Source array not long enough' in a block copy, or some such. so even though I got a valid response from the other side it was useless to me.

Wondering if we can get this fixed? I would go ahead and fix it myself but I'm not geared up for the version of C# that the project needs to be compiled with...

@LADSoft
Copy link
Contributor Author

LADSoft commented Nov 17, 2022

i fixed this in #117 , closing this issue.

@LADSoft LADSoft closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant